485862 - testing/mochitest/ssltunnel fails to find system nss includes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jeremy Huddleston]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3
Build Identifier: xulrunner 1.9.0.7 OSX/darwin X11

I'm building xulrunner-1.9.0.7 for darwin/X11.  I have nss installed and am using the system nss and nspr via these configure options:
        --with-system-nspr \
        --with-nspr-prefix=${prefix} \
        --with-system-nss \
        --with-nss-prefix=${prefix} \

testing/mochitest/ssltunnel fails to build because it is not including ${with-nss-prefix}/include/nss in the c-pre-processor's search path.

/opt/local/var/macports/build/_Users_jeremy_src_macports-trunk_dports_devel_xulrunner/work/mozilla/testing/mochitest/ssltunnel $ sudo make
/opt/local/bin/gmake export
gmake[1]: Entering directory `/opt/local/var/macports/build/_Users_jeremy_src_macports-trunk_dports_devel_xulrunner/work/mozilla/testing/mochitest/ssltunnel'
gmake[1]: Leaving directory `/opt/local/var/macports/build/_Users_jeremy_src_macports-trunk_dports_devel_xulrunner/work/mozilla/testing/mochitest/ssltunnel'
/opt/local/bin/gmake libs
gmake[1]: Entering directory `/opt/local/var/macports/build/_Users_jeremy_src_macports-trunk_dports_devel_xulrunner/work/mozilla/testing/mochitest/ssltunnel'
ssltunnel.cpp
/usr/bin/g++-4.0 -o ssltunnel.o -c -I../../../dist/include/system_wrappers -include ../../../config/gcc_hidden.h -DOSTYPE=\"Darwin9.6.0\" -DOSARCH=Darwin  -I. -I. -I../../../dist/include/nspr -I../../../dist/include/nss -I../../../dist/include   -I../../../dist/include -I/opt/local/include/nspr -I/opt/local/include  -I/opt/local/include  -I../../../dist/sdk/include -I/opt/local/include   -fPIC  -I/opt/local/include  -I/opt/local/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -O2 -fno-strict-aliasing -fpascal-strings -fno-common -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2  -I/opt/local/include  -I/opt/local/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/ssltunnel.pp ssltunnel.cpp
In file included from ssltunnel.cpp:48:
../../../dist/include/system_wrappers/nss.h:3:22: error: nss.h: No such file or directory
In file included from ssltunnel.cpp:49:
../../../dist/include/system_wrappers/pk11func.h:3:27: error: pk11func.h: No such file or directory
In file included from ssltunnel.cpp:50:
../../../dist/include/system_wrappers/key.h:3:22: error: key.h: No such file or directory
In file included from ssltunnel.cpp:51:
../../../dist/include/system_wrappers/keyt.h:3:23: error: keyt.h: No such file or directory
In file included from ssltunnel.cpp:52:
../../../dist/include/system_wrappers/ssl.h:3:22: error: ssl.h: No such file or directory
ssltunnel.cpp:73: error: expected `)' before ‘*’ token
ssltunnel.cpp:75: error: expected type-specifier before ‘CERTCertificate’
ssltunnel.cpp:77: error: ISO C++ forbids declaration of ‘CERTCertificate’ with no type
ssltunnel.cpp:77: error: expected ‘;’ before ‘*’ token
ssltunnel.cpp: In destructor ‘AutoCert::~AutoCert()’:
ssltunnel.cpp:74: error: ‘cert_’ was not declared in this scope
ssltunnel.cpp:74: error: ‘CERT_DestroyCertificate’ was not declared in this scope
ssltunnel.cpp: At global scope:
ssltunnel.cpp:82: error: expected `)' before ‘*’ token
ssltunnel.cpp:84: error: expected type-specifier before ‘SECKEYPrivateKey’
ssltunnel.cpp:86: error: ISO C++ forbids declaration of ‘SECKEYPrivateKey’ with no type
ssltunnel.cpp:86: error: expected ‘;’ before ‘*’ token
ssltunnel.cpp: In destructor ‘AutoKey::~AutoKey()’:
ssltunnel.cpp:83: error: ‘key_’ was not declared in this scope
ssltunnel.cpp:83: error: ‘SECKEY_DestroyPrivateKey’ was not declared in this scope
ssltunnel.cpp: At global scope:
ssltunnel.cpp:117: error: expected constructor, destructor, or type conversion before ‘*’ token
ssltunnel.cpp:118: error: expected constructor, destructor, or type conversion before ‘*’ token
ssltunnel.cpp: In function ‘void SignalShutdown()’:
ssltunnel.cpp:127: error: ‘shutdown_lock’ was not declared in this scope
ssltunnel.cpp:127: error: ‘PR_Lock’ was not declared in this scope
ssltunnel.cpp:128: error: ‘shutdown_condvar’ was not declared in this scope
ssltunnel.cpp:128: error: ‘PR_NotifyCondVar’ was not declared in this scope
ssltunnel.cpp:129: error: ‘PR_Unlock’ was not declared in this scope
ssltunnel.cpp: In function ‘void StartServer(void*)’:
ssltunnel.cpp:202: error: ‘PK11_FindCertFromNickname’ was not declared in this scope
ssltunnel.cpp:203: error: no match for ‘operator!’ in ‘!cert’
ssltunnel.cpp:203: note: candidates are: operator!(bool) <built-in>
ssltunnel.cpp:209: error: ‘PK11_FindKeyByAnyCert’ was not declared in this scope
ssltunnel.cpp:210: error: no match for ‘operator!’ in ‘!privKey’
ssltunnel.cpp:210: note: candidates are: operator!(bool) <built-in>
ssltunnel.cpp:237: error: ‘SSL_ImportFD’ was not declared in this scope
ssltunnel.cpp:245: error: ‘kt_rsa’ was not declared in this scope
ssltunnel.cpp:245: error: ‘SSL_ConfigSecureServer’ was not declared in this scope
ssltunnel.cpp:246: error: ‘SECSuccess’ was not declared in this scope
ssltunnel.cpp: At global scope:
ssltunnel.cpp:271: error: ‘PK11SlotInfo’ was not declared in this scope
ssltunnel.cpp:271: error: ‘slot’ was not declared in this scope
ssltunnel.cpp:271: error: expected primary-expression before ‘retry’
ssltunnel.cpp:271: error: expected primary-expression before ‘void’
ssltunnel.cpp:271: error: initializer expression list treated as compound expression
ssltunnel.cpp:272: error: expected ‘,’ or ‘;’ before ‘{’ token
ssltunnel.cpp: In function ‘int main(int, char**)’:
ssltunnel.cpp:331: error: ‘shutdown_lock’ was not declared in this scope
ssltunnel.cpp:331: error: ‘PR_NewLock’ was not declared in this scope
ssltunnel.cpp:337: error: ‘shutdown_condvar’ was not declared in this scope
ssltunnel.cpp:337: error: ‘PR_NewCondVar’ was not declared in this scope
ssltunnel.cpp:341: error: ‘PR_DestroyLock’ was not declared in this scope
ssltunnel.cpp:345: error: ‘PK11_SetPasswordFunc’ was not declared in this scope
ssltunnel.cpp:350: error: ‘NSS_Init’ was not declared in this scope
ssltunnel.cpp:350: error: ‘SECSuccess’ was not declared in this scope
ssltunnel.cpp:357: error: ‘PR_DestroyCondVar’ was not declared in this scope
ssltunnel.cpp:358: error: ‘PR_DestroyLock’ was not declared in this scope
ssltunnel.cpp:362: error: ‘NSS_SetDomesticPolicy’ was not declared in this scope
ssltunnel.cpp:362: error: ‘SECSuccess’ was not declared in this scope
ssltunnel.cpp:365: error: ‘PR_DestroyCondVar’ was not declared in this scope
ssltunnel.cpp:366: error: ‘PR_DestroyLock’ was not declared in this scope
ssltunnel.cpp:367: error: ‘NSS_Shutdown’ was not declared in this scope
ssltunnel.cpp:372: error: ‘SSL_ConfigServerSessionIDCache’ was not declared in this scope
ssltunnel.cpp:372: error: ‘SECSuccess’ was not declared in this scope
ssltunnel.cpp:375: error: ‘PR_DestroyCondVar’ was not declared in this scope
ssltunnel.cpp:376: error: ‘PR_DestroyLock’ was not declared in this scope
ssltunnel.cpp:377: error: ‘NSS_Shutdown’ was not declared in this scope
ssltunnel.cpp:388: error: ‘PR_Lock’ was not declared in this scope
ssltunnel.cpp:389: error: ‘PR_WaitCondVar’ was not declared in this scope
ssltunnel.cpp:390: error: ‘PR_Unlock’ was not declared in this scope
ssltunnel.cpp:396: error: ‘PR_DestroyCondVar’ was not declared in this scope
ssltunnel.cpp:397: error: ‘PR_DestroyLock’ was not declared in this scope
ssltunnel.cpp:398: error: ‘NSS_Shutdown’ was not declared in this scope
ssltunnel.cpp:398: error: ‘SECFailure’ was not declared in this scope
gmake[1]: *** [ssltunnel.o] Error 1
gmake[1]: Leaving directory `/opt/local/var/macports/build/_Users_jeremy_src_macports-trunk_dports_devel_xulrunner/work/mozilla/testing/mochitest/ssltunnel'
make: *** [default] Error 2



Reproducible: Always

Comment 1

[Jeremy Huddleston]

Note that 'make showbuild | grep INCLUDE' reveals:

OS_INCLUDES        = -I/opt/local/include/nspr -I/opt/local/include  -I/opt/local/include 
INCLUDES           =  -I. -I. -I../../../dist/include/nspr -I../../../dist/include/nss -I../../../dist/include   -I../../../dist/include -I/opt/local/include/nspr -I/opt/local/include  -I/opt/local/include  -I../../../dist/sdk/include

so it looks like the system nspr is being included in the search path, but nss is being dropped somehow.


config/autoconf.mk shows:
NSPR_CONFIG     = /opt/local/bin/nspr-config
NSPR_CFLAGS     = -I/opt/local/include/nspr
NSPR_LIBS       = -L/opt/local/lib -lplds4 -lplc4 -lnspr4 -L/opt/local/lib

NSS_CONFIG      = /opt/local/bin/nss-config
NSS_CFLAGS      = -I/opt/local/include/nss
NSS_LIBS        = -L/opt/local/lib/nss -lssl3 -lsmime3 -lnss3 -lnssutil3 -lcrmf
NSS_DEP_LIBS    = 


---

This patch fixes the problem for me:

--- config/autoconf.mk.in.orig	2009-03-29 22:07:24.000000000 -0700
+++ config/autoconf.mk.in	2009-03-29 22:07:54.000000000 -0700
@@ -278,7 +278,7 @@ OS_LDFLAGS	= @LDFLAGS@
 OS_COMPILE_CFLAGS = $(OS_CPPFLAGS) @COMPILE_CFLAGS@
 OS_COMPILE_CXXFLAGS = $(OS_CPPFLAGS) @COMPILE_CXXFLAGS@
 
-OS_INCLUDES	= $(NSPR_CFLAGS) $(JPEG_CFLAGS) $(PNG_CFLAGS) $(ZLIB_CFLAGS) $(LCMS_CFLAGS)
+OS_INCLUDES	= $(NSPR_CFLAGS) $(NSS_CFLAGS) $(JPEG_CFLAGS) $(PNG_CFLAGS) $(ZLIB_CFLAGS) $(LCMS_CFLAGS)
 OS_LIBS		= @LIBS@
 ACDEFINES	= @MOZ_DEFINES@

Comment 2

[Jeremy Huddleston]

Attachment: Allow building against system nss

I hope I'm doing the review process correctly.  Please tell me if setting "review" to "?" was not the correct thing to do.

Comment 3

[Dão Gottwald [:dao]]

Patch doesn't apply anymore, let alone that it's not an hg patch.

Comment 4

[Jeremy Huddleston]

Attachment: Allow building against system nss

updated to mozilla-central as of today

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/dddb7146a7d5

Thanks Jeremy!

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Copy it to comm-central [Checkin: Comment 7]

Actually, before adding this, c-c NSS_CFLAGS support is unused :-|

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 427528 [details] [diff] [review]
(Bv1) Copy it to comm-central
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/614da12a014a