485934 - [sr] Increment gecko.handlerService.defaultHandlersVersion in order for the Mibbit irc handler to work

Status: RESOLVED FIXED

(Mozilla Localizations :: sr / Serbian, defect)

Description

[Staś Małolepszy :stas]

The following revision added the Mibbit handler to region.properties:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/sr/diff/8eb3fe7142a8/browser/chrome/browser-region/region.properties

Please note that this landing is not complete. For the handler to work on all profiles, the gecko.handlerService.defaultHandlersVersion pref (also in region.properties) needs to be incremented by 1.

Please submit a patch for a review.

I'm also not sure about the Serbian Cyrillic transcription. Is this a common thing to do with proper names and trademarks?

Please also note that any changes to region.properties (and searchplugins/) need to go through a review process. Thanks for keeping that in mind in the future :)

Comment 1

[Filip Miletic]

(In reply to comment #0)
> Please submit a patch for a review.
Ok, will do.

> I'm also not sure about the Serbian Cyrillic transcription. Is this a common
> thing to do with proper names and trademarks?

All names, all trademarks are transliterated if we're following the language rules.

Are there any other concerns about this?  Companies tend to oppose transliteration, but: http://farm1.static.flickr.com/1/3886323_811a6ebcb8.jpg (this is not from Serbia, but you catch my drift)  

> Please also note that any changes to region.properties (and searchplugins/)
> need to go through a review process. Thanks for keeping that in mind in the
> future :)

Sorry.  This must be the third time that I forget about this.  I can think of no excuses.

Comment 2

[Staś Małolepszy :stas]

Filip, thanks for explanations. I e-mailed Mibbit to ask what their preference is regarding transliteration. I believe that we should only transliterate brand names when their owners ask for it or agree to it. I think it's always a good thing to ask, just to be on the safe side.

While waiting for Mibbit to respond, would you mind providing a patch reverting the transliterations (including browser.search.order.2=Јаху (Yahoo); this won't work without changing the search plug-in file itself)? Thanks!

Comment 3

[Filip Miletic]

Attachment: Reverts all transliterations for the mail handlers, for the time being; increments the version count

Here's the requested patch. Please be so kind to review ASAP.  

Also would it be possible for you to apply this patch on my behalf?  I will be away from the computer during the extended weekend, and it will be most difficult for me to do so.  

Thanks,
f

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 370809 [details] [diff] [review]
Reverts all transliterations for the mail handlers, for the time being; increments the version count

Thanks Filip, and sure, I'll land it. Moving the review request on to me and cancelling the approval requests - we'll fix it only on 1.9.1 and central.

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 370809 [details] [diff] [review]
Reverts all transliterations for the mail handlers, for the time being; increments the version count

Thanks Filip. I landed the patch on 1.9.1: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/sr/rev/c7afb9ba8fc6

Can you land it on l10n-central, too?

Comment 6

[Filip Miletic]

Fixed on 1.9.1 courtesy Stas; I didn't land it on central yet, but my internal repo is patched, so the fix will go in with my next commit there.

Comment 7

[Staś Małolepszy :stas]

Cool, thanks Filip.