485974 - [ru] Change browser.search.siteSearchURL to Yandex

Status: RESOLVED FIXED

(Mozilla Localizations :: ru / Russian, defect)

Description

[Staś Małolepszy :stas]

Since Yandex is the default search engine in the Russian builds, we should change the search provider in the browser.search.siteSearchURL pref from Google, too.

The details on the exact URL to use will follow once we get confirmation from Yandex.

Comment 1

[Staś Małolepszy :stas]

Kev writes that Yandex has asked to use &surl= or &site=. &surl will give results for that hostname specifically. &site will give results for sub-hosts/domains as well. 

So we should decide between on of the two following URLs:
http://yandex.ru/yandsearch?clid=46511&site={moz:domain}text={searchTerms}
http://yandex.ru/yandsearch?clid=46511&surl={moz:domain}text={searchTerms}

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I think we want "site", to match what Google does. If you're on a subdomain we'll pass in that entire subdomain, so searches will already be restricted somewhat.

Comment 3

[Alexander L. Slovesnik]

Attachment: Patch

As discussed with Kev, we are going to use "&surl".

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Do you mind sharing the reasoning that led to that decision? Just curious.

Comment 5

[Alexander L. Slovesnik]

(In reply to comment #4)
> Do you mind sharing the reasoning that led to that decision? Just curious.
It was Kev's call. Quoting him - "&site gives sub-domains of the domain being searched, which may not aways be optimal".

Comment 6

[Staś Małolepszy :stas]

From wat I've seen, both parameters seem to give very similar results.

I tested:
* http://yandex.ru/yandsearch?text=obama&site=yahoo.com
* http://yandex.ru/yandsearch?text=obama&surl=yahoo.com

And the results were the same, coming from yahoo.com, news.yahoo.com, video.yahoo.com, shine.yahoo.com, finance.yahoo.com etc.

Then I tested:
* http://yandex.ru/yandsearch?text=obama&site=video.yahoo.com
* http://yandex.ru/yandsearch?text=obama&surl=video.yahoo.com

And the results were again the same, all coming from video.yahoo.com only.

The fact that the behavior of the two is currently very similar (if not identical) is something we might want to discuss with Yandex. Given the specification from comment 1, my vote goes to &site. If the user wants to search yahoo.com, I think it's OK to show her the results from all sub-domains, too.

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 371904 [details] [diff] [review]
Patch

I think this should be a beta4 blocker for [ru] so let's try to fix this by tomorrow. Regardless of the surl/site decision, I have to r- the attached patch. The "text" parameter needs to be preceded by an "&".

>+browser.search.siteSearchURL = http://yandex.ru/yandsearch?clid=46511&surl={moz:domain}text={searchTerms}

Unghost, Kev, are you OK with using &site here, as Gavin suggested?

Comment 8

[Alexander L. Slovesnik]

Attachment: Patch v.2

> Unghost, Kev, are you OK with using &site here, as Gavin suggested?
I'm fine with &site.

Comment 9

[Kev Needham [:kev]]

Only concern I have is with smaller sites that use a common domain (e.g. wordpress.com) for a majority of sites. I'm not so worried about results on larger sites, as they're not really the target for this feature (form what I understand). 

I have no preference either way, especially if the results do not seem to differ appreciably. so, yes, I'm ok with whichever we go with.

Comment 10

[Staś Małolepszy :stas]

Comment on attachment 372645 [details] [diff] [review]
Patch v.2

Let's go with &site, at least for now.

r=me. Unghost, can you land this patch before the today's deadline for beta4 opt-ins? If so, please land this patch on both branches using a descriptive check-in comment, mentioning the bug number and my review (e.g. "Bug 485974: Change browser.search.siteSearchURL to Yandex, r=stas").

Please use fixed1.9.1 and verified1.9.1 keywords in this bug to track landing and verification on the 1.9.1 branch.

If not, I'll land it myself and update the opt-in revision.

Comment 11

[Staś Małolepszy :stas]

I landed the patch on 1.9.1: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ru/rev/1fce01ed18e5

Unghost, mind landing in on l10n-central, too?

Comment 12

[Alexander L. Slovesnik]

Fixed on l10n-central:
http://hg.mozilla.org/l10n-central/ru/rev/b17f01bae754