486074 - Objects not serialized properly under JSON WebServices (Bug.get's "internals" object)

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Max Kanat-Alexander]

For some reason, our JSON WebServices interface is not properly converting objects into hashes, even though we have specified that it should. It's just sending undef for objects, instead. This may be a bug in JSON::RPC.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Turns out the JSON.pm docs say that we do indeed need to specify our own TO_JSON method. Thankfully, this was really easy.

In the future, I think we might want to modify this to only return "name" and "id", and then we could start putting objects directly into our return values.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 427688 [details] [diff] [review]
v1

Agreed that we should eventually be more careful in what we return but works well for now. r=dkl

Comment 3

[Max Kanat-Alexander]

Cool, thanks. :-)

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Object.pm
Committed revision 7023.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified Bugzilla/Object.pm
Committed revision 6997.