486082 - Add bookmark dialog shouldn't be visible in settings view.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Chwiej Pawel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090223 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090317 Fennec/1.0b1




Reproducible: Always

Steps to Reproduce:
1. Navigate to any page.
2. Open right control panel.
3. Invoke add bookmark dialog.
4. Click on settings button.
Actual Results:  
Add bookmark dialog is displayed on top of the settings view(check screenshot).

Expected Results:  
Add bookmark dialog shouldn't be visible there.

Comment 1

[Chwiej Pawel]

Attachment: screenshot

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 489510 exposes a vertical positioning problem too.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch moves the z-order of the <vbox> used for the bookmark editor so it will not display over the browser tool panels. It hides the sidebar controls a little sooner and positions the editor below the toolbar, even if the toolbar is partially visible.

This patch does not allow the editor to pan with the sidebars. WidgetStack is not handling it correctly. Findbar has the same problem, so I will spin off a new bug for that part.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 375616 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>     this._panel = document.getElementById("bookmark-container");
>-    this._panel.width = container.boxObject.width;
>+    this._panel.top = (top < 0 ? 0 : top);

why is the width setting no longer necessary?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #5)
> (From update of attachment 375616 [details] [diff] [review])
> >diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
> 
> >     this._panel = document.getElementById("bookmark-container");
> >-    this._panel.width = container.boxObject.width;
> >+    this._panel.top = (top < 0 ? 0 : top);
> 
> why is the width setting no longer necessary?

We set it in BrowserUI.sizeControls

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Filed bug 491811 for the WidgetStack panning issues.

http://hg.mozilla.org/mobile-browser/rev/5a032f078823

Comment 8

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

verified with maemo nightly 20090818