Closed Bug 486082 Opened 14 years ago Closed 14 years ago

Add bookmark dialog shouldn't be visible in settings view.

Categories

(Firefox for Android Graveyard :: Bookmarks, defect)

x86
Linux
defect
Not set
normal

Tracking

(fennec1.0b2+)

VERIFIED FIXED
Tracking Status
fennec 1.0b2+ ---

People

(Reporter: p.chwiej, Assigned: mfinkle)

References

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090223 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090317 Fennec/1.0b1




Reproducible: Always

Steps to Reproduce:
1. Navigate to any page.
2. Open right control panel.
3. Invoke add bookmark dialog.
4. Click on settings button.
Actual Results:  
Add bookmark dialog is displayed on top of the settings view(check screenshot).

Expected Results:  
Add bookmark dialog shouldn't be visible there.
Attached image screenshot
tracking-fennec: --- → ?
Assignee: nobody → mark.finkle
Status: UNCONFIRMED → NEW
tracking-fennec: ? → 1.0b2+
Ever confirmed: true
Bug 489510 exposes a vertical positioning problem too.
Attached patch patchSplinter Review
This patch moves the z-order of the <vbox> used for the bookmark editor so it will not display over the browser tool panels. It hides the sidebar controls a little sooner and positions the editor below the toolbar, even if the toolbar is partially visible.

This patch does not allow the editor to pan with the sidebars. WidgetStack is not handling it correctly. Findbar has the same problem, so I will spin off a new bug for that part.
Attachment #375616 - Flags: review?(gavin.sharp)
Attachment #375616 - Flags: review?(gavin.sharp) → review+
Comment on attachment 375616 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>     this._panel = document.getElementById("bookmark-container");
>-    this._panel.width = container.boxObject.width;
>+    this._panel.top = (top < 0 ? 0 : top);

why is the width setting no longer necessary?
(In reply to comment #5)
> (From update of attachment 375616 [details] [diff] [review])
> >diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
> 
> >     this._panel = document.getElementById("bookmark-container");
> >-    this._panel.width = container.boxObject.width;
> >+    this._panel.top = (top < 0 ? 0 : top);
> 
> why is the width setting no longer necessary?

We set it in BrowserUI.sizeControls
Filed bug 491811 for the WidgetStack panning issues.

http://hg.mozilla.org/mobile-browser/rev/5a032f078823
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
verified with maemo nightly 20090818
Status: RESOLVED → VERIFIED
Component: General → Bookmarks
You need to log in before you can comment on or make changes to this bug.