Closed
Bug 486096
Opened 16 years ago
Closed 16 years ago
TraceMonkey: ARM BKPT instructions are not properly encoded.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jbramley, Assigned: jbramley)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
463 bytes,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
NativeARM.h encodes BKPT using "E << 24" for the condition code. This is incorrect, as the shift should be 28. In addition, the #defined COND_AL macro should be used.
Note: The BKPT instruction in Trace Monkey is never intended to be executed, but acts as a sensible replacement for locations which should never be executed. This can occur when a "LDR PC, xxx" is patched up later with a "B xxx", for example. Because this should never be executed, I have labelled this bug as "trivial".
Attachment #370176 -
Flags: review?(vladimir)
Attachment #370176 -
Flags: review?(vladimir) → review+
|
Assignee | |
Comment 1•16 years ago
|
||
Needs check-in on tracemonkey.
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
Keywords: checkin-needed
Whiteboard: fixed-in-tracemonkey
|
|
||
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•