486186 - Reminder based on end/due date changes to start date after restart (RELATED property missing in VALARM component)

Status: VERIFIED FIXED

(Calendar :: Alarms, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090331 Calendar/1.0pre

Steps to Reproduce:
1. Start with clean profile
2. Create new event with a custom alarm "15 minutes before the event ends"
3. Check VALARM component after exporting or copying the event

Actual Results:
RELATED property missing in VALARM component.

If created with Sunbird 1.0pre (2009033105):
    BEGIN:VALARM
    ACTION:DISPLAY
    TRIGGER;VALUE=DURATION:-PT15M
    DESCRIPTION:Default Mozilla Description
    END:VALARM

If created with Sunbird 0.9:
    BEGIN:VALARM
    TRIGGER;VALUE=DURATION;RELATED=END:-PT15M
    DESCRIPTION:Mozilla Alarm: New Event
    ACTION:DISPLAY
    END:VALARM

Tested with storage and ics provider.

Comment 1

[Stefan Sitter [:ssitter]]

Regression range: Works in Sunbird 1.0pre (20090115031904)
                  Fails in Sunbird 1.0pre (20090116032231)

Checkins during regression range: <https://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-01-15+03:19:04&enddate=2009-01-16+03:22:31>

Seems to be regressed by Bug 471973.

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: xpcshell testcase

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 370280 [details] [diff] [review]
xpcshell testcase

r=philipp if you move this into test_alarm.js. I don't think we need an extra file for this?

Comment 4

[Stefan Sitter [:ssitter]]

I prefer the way used in other parts of mozilla - use a separate file for each test if possible - because |make check| reports what file failed. Using one big single test file requires additional work, e.g. by adding dump() statements, if you want to know on what specific test it failed.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

In that case, maybe we should use subfolders for categories, i.e

test/unit
 +-alarms
   --test_bug486186.js
 +-providers
   --...

I'm fine with using flat folders for now though so go ahead and check it in.

Comment 6

[Stefan Sitter [:ssitter]]

Changing summary to describe the user error instead of the technical error.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 8

[Stefan Sitter [:ssitter]]

Comment on attachment 374250 [details] [diff] [review]
Fix - v1

r=ssitter

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/07de5fc8cd8e>

-> FIXED

Comment 10

[Stefan Sitter [:ssitter]]

Comment on attachment 370280 [details] [diff] [review]
xpcshell testcase

Pushed to comm-central: <https://hg.mozilla.org/comm-central/rev/807e2a2ae5e4>

Comment 11

[Stefan Sitter [:ssitter]]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090611 Calendar/1.0pre (BuildID: 20090611031611)