Closed Bug 486186 Opened 13 years ago Closed 13 years ago
Reminder based on end/due date changes to start date after restart (RELATED property missing in VALARM component)
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090331 Calendar/1.0pre Steps to Reproduce: 1. Start with clean profile 2. Create new event with a custom alarm "15 minutes before the event ends" 3. Check VALARM component after exporting or copying the event Actual Results: RELATED property missing in VALARM component. If created with Sunbird 1.0pre (2009033105): BEGIN:VALARM ACTION:DISPLAY TRIGGER;VALUE=DURATION:-PT15M DESCRIPTION:Default Mozilla Description END:VALARM If created with Sunbird 0.9: BEGIN:VALARM TRIGGER;VALUE=DURATION;RELATED=END:-PT15M DESCRIPTION:Mozilla Alarm: New Event ACTION:DISPLAY END:VALARM Tested with storage and ics provider.
Regression range: Works in Sunbird 1.0pre (20090115031904) Fails in Sunbird 1.0pre (20090116032231) Checkins during regression range: <https://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-01-15+03:19:04&enddate=2009-01-16+03:22:31> Seems to be regressed by Bug 471973.
Attachment #370280 - Attachment description: xpshell testcase → xpcshell testcase
Comment on attachment 370280 [details] [diff] [review] xpcshell testcase r=philipp if you move this into test_alarm.js. I don't think we need an extra file for this?
Attachment #370280 - Flags: review?(philipp) → review+
I prefer the way used in other parts of mozilla - use a separate file for each test if possible - because |make check| reports what file failed. Using one big single test file requires additional work, e.g. by adding dump() statements, if you want to know on what specific test it failed.
In that case, maybe we should use subfolders for categories, i.e test/unit +-alarms --test_bug486186.js +-providers --... I'm fine with using flat folders for now though so go ahead and check it in.
Changing summary to describe the user error instead of the technical error.
Summary: RELATED property missing in VALARM component after event creation → Reminder based on end/due date changes to start date after restart (RELATED property missing in VALARM component)
Flags: blocking-calendar1.0? → blocking-calendar1.0+
Attachment #374250 - Flags: review?(ssitter) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/07de5fc8cd8e> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Windows XP → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Comment on attachment 370280 [details] [diff] [review] xpcshell testcase Pushed to comm-central: <https://hg.mozilla.org/comm-central/rev/807e2a2ae5e4>
Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090611 Calendar/1.0pre (BuildID: 20090611031611)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.