486192 - Buildbot, unittest: MozillaMochitest() new |harnessErrorsRe| handling doesn't work on production boxes

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

Regression from bug 484231 patch Av2a:

(In reply to comment #13)
> (From update of attachment 369803 [details] [diff] [review])
> http://hg.mozilla.org/build/buildbotcustom/rev/6ed37da063bd

This was deployed today and there is a regression:
the |harnessErrorsRe| handling in MozillaMochitest() seems not to work :-/

See
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1238518265.1238526202.13122.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/31 09:51:05
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 293868 bytes during test execution
TinderboxPrint: mochitest-plain<br/>78679/0/1252
should be 78679/0/1252 LEAK

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1238510558.1238519770.31125.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/31 07:42:38
TEST-UNEXPECTED-FAIL | runtests-leaks | negative leaks caught!
TinderboxPrint: mochitest-plain<br/>78772/0/1256
should be 78772/0/1256 LEAK

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1238520505.1238527919.17373.gz&fulltext=1
OS X 10.5.2 mozilla-1.9.1 unit test on 2009/03/31 10:28:25
TEST-UNEXPECTED-FAIL | (automation.py) | Browser crashed (minidump found)
TinderboxPrint: mochitest-plain<br/><em class="testfail">T-FAIL</em>
should be T-FAIL CRASH L-FAIL
}

Yet, I can't reproduce on my Windows 2000, even with copy+pasting the box logs :-(
I get the expected summaries.

NB: I think this does not "need" to be backed out, but if you want to then it could be.

Comment 1

[Chris AtLee [:catlee]]

Attachment: Don't try and match the end of line

Trying to match the end of line with "$" fails because the buildbot logs are in CRLF format for some reason, and "$" only seems to match before LF.

Comment 2

[alice nodelman [:alice] [:anode]]

Catlee, assigning to you as you have contributed the patch.  If this isn't appropriate please put it back in the triage queue.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 370316 [details] [diff] [review]
Don't try and match the end of line

changeset:   239:bbaa4ae601e8

Comment 4

[Serge Gautherie (:sgautherie)]

V.Fixed, per oranges with correct summary on both FF 3.6 and 3.5 waterfalls.