486207 - previewed persona doesn't reset when gallery page is closed

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

If you are previewing a persona by hovering over its thumbnail in the gallery on getpersonas.com, and then you close the gallery page without mousing out of the thumbnail (f.e. by pressing Ctrl/Cmd-W or by going to another URL in that tab), the extension doesn't reset the persona to the previously selected persona.

This bug is caused by Core bug 467684.  Until that is fixed (if ever), a workaround would be for Personas to watch tabs that have generated PreviewPersona events and reset the persona when the user closes the tab or goes to another page in it.

Comment 1

[Ryan Doherty (:rdoherty)]

Another workaround might be for the page that triggers a PreviewPersona event to listen for a onbeforeunload event and trigger the reset event. It might work.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #1)
> Another workaround might be for the page that triggers a PreviewPersona event
> to listen for a onbeforeunload event and trigger the reset event. It might
> work.

Brilliant! That works great:

http://people.mozilla.com/~myk/personas/set-persona-from-web-page-test.html

(Add people.mozilla.com to extensions.personas.authorizedHosts before testing.)

Comment 3

[Ryan Doherty (:rdoherty)]

Cool, I've assigned this to myself for implementation.

Comment 5

[Ryan Doherty (:rdoherty)]

Marking this bug fixed as bug 520173 fixes the issue in Firefox.