486215 - Windows Memory Profiler config does not compile after VMPI changes

Status: VERIFIED DUPLICATE of bug 486401

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Rishit Shah]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.8) Gecko/2009032608 Firefox/3.0.8
Build Identifier: 

Warning related to deprecated _snprintf function causes compilation to fail.

Reproducible: Always

Comment 1

[Rishit Shah]

Attachment: [v1] patch for Memory Profiler build breakage

Comment 2

[Tommy Reilly]

Comment on attachment 370301 [details] [diff] [review]
[v1] patch for Memory Profiler build breakage

If MMGC_MEMORY_PROFILER is defined for release builds why didn't they fail to build?

Comment 3

[Rishit Shah]

Because MMGC_MEMORY_PROFILER is not defined for any target in shell.

Comment 4

[Tommy Reilly]

Hmm, I thought I had it turned on in winbuild.h but I'm confusing branches.  I'd like to turn it on for all builds (windows only right now) and see if the perf changes.

Comment 5

[Rishit Shah]

Attachment: [v2] patch

Updating previous patch with changes to fix inconsistent usage of MMGC_MEM_TAG/MMGC_MEM_TYPE.

No modifications to changes in previous patch.

Comment 6

[Rishit Shah]

Comment on attachment 371700 [details] [diff] [review]
[v2] patch

marking this as obsolete because this bug is a duplicate of 486401.

Comment 8

[Tommy Reilly]

Comment on attachment 371700 [details] [diff] [review]
[v2] patch


I have MMGC_MEMORY_PROFILER enabled for all builds in mainline winbuild.h and there is a purpose to the MMGC_MEM_TYPE=NULL, again see the mainline.  I also changed all String allocations to be dumped into the "String" category

Comment 9

[Rishit Shah]

Gotcha.  I made the change because SetMemType() didn't have the NULL check for incoming pointer.

I will make related changes to redux and upload a patch to bug# 486401.