486242 - reftest for 480267 fails on 1.9.1 branch due to early onload firing

Status: RESOLVED DUPLICATE of bug 477880

(Core :: CSS Parsing and Computation, defect)

Description

[John Daggett (:jtd)]

As part of the fix for bug 480267 I created a reftest that compares pages with a large set of downloadable fonts under different style/weight settings.  The test renders fine both on trunk and on 1.9.1 with the patch but it's failing under the reftest harness because the onload handler for the test page is firing early, causing the wrong snapshot to be taken and aborting the font downloads on the test page.  I'm going to mark the test random for now.

Steps:

1. Enable downloadable font logging:

  export NSPR_LOG_MODULES=userfonts:5,fontdownloader:5

2. Run reftests in reftests/font-face directory

Result: the last test, synthetic-weight-style.html will fail and the images will show the test page rendered without downloadable fonts

To view the tests (due to access controls need HTTP load):

http://people.mozilla.org/~jdaggett/font-face/synthetic-weight-style.html
http://people.mozilla.org/~jdaggett/font-face/synthetic-weight-style-ref.html

Comment 1

[Boris Zbarsky [:bzbarsky]]

John, does applying the patch for bug 477880 help?  Maybe we should backport that to branch....

Comment 2

[John Daggett (:jtd)]

Yup, that was it!

Comment 3

[John Daggett (:jtd)]

Pushing 477880 to 1.9.1 fixes this.  Will remove 'random' from reftest as part of fix for bug 468387, which also affects the reftest on Windows.