486256 - Mochitest test_Scriptaculous.html (all but 2) results fail to be actually logged

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Serge Gautherie (:sgautherie)]

Noticed while looking into bug 451287:
(Reproduced on my local Win2K)
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237154733.1237161001.15457.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/15 15:05:33

*** 32176 INFO Running /tests/dom/tests/mochitest/ajax/scriptaculous/test_Scriptaculous.html...
*** 32177 INFO TEST-PASS | /tests/dom/tests/mochitest/ajax/scriptaculous/test_Scriptaculous.html | testDummy
*** 32178 INFO TEST-PASS | /tests/dom/tests/mochitest/ajax/scriptaculous/test_Scriptaculous.html | testMultipleTestRunner
*** 32180 INFO Running /tests/dom/tests/mochitest/bugs/test_bug132255.html...
}

With my local:
*run alone: 818 checks.
*run in the whole suite: 694 checks ("only") "seen" be the harness;
 but 2 only are logged.
 (Yet, these 692 "missing" 'TEST-PASS' are added to the "Passed" count.)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Remove the extra test

We don't support multiple test runners in one file. The second test causes us to call SimpleTest.finish while the final test is still being run.

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 439536 [details] [diff] [review]
Remove the extra test


Nit: I'd suggest to comment out this code and add a comment, rather than remove it. (To ease diff, ...)

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

(In reply to comment #2)
> Nit: I'd suggest to comment out this code and add a comment, rather than remove
> it. (To ease diff, ...)

Sure.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/fe051655d85e

Comment 5

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=8350686&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central opt test mochitests-2/5 on 2012-01-05 09:35:37 PST
{
12491 INFO TEST-START | /tests/dom/tests/mochitest/ajax/scriptaculous/test_Scriptaculous.html
12492 INFO TEST-PASS | /tests/dom/tests/mochitest/ajax/scriptaculous/test_Scriptaculous.html | testDisposesProperly - 10 assertions, 0 failures, 0 errors
...
13192 INFO TEST-PASS | /tests/dom/tests/mochitest/ajax/scriptaculous/test_Scriptaculous.html | testAssertVisible - 26 assertions, 0 failures, 0 errors
13193 INFO TEST-END | /tests/dom/tests/mochitest/ajax/scriptaculous/test_Scriptaculous.html | finished in 14114ms
}

702 checks logged :-)

V.Fixed