486444 - win32_info.txt has stray characters in mercurial release automation

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Both the actual 3.1b3 release and a mock 3.5b4 release end up with win32_info.txt looking like 
  buildID=20090330224133 \r\n
while linux and mac have
  buildID=20090331221646\n
(ie windows has a trailing space and CRLF line ending). For comparison the 1.9.0 release automation produces files without spaces or any line endings.

The extra characters cause problems for update verification by breaking the config over two lines, like this:
release="3.1b3" ... build_id="20090305152042 
" locales="af ...
This also causes an extra line to be written into the patcher config during update generation, but this is only cosmetic.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Use the bash environment on all platforms

This appears to do the trick but I need to check by doing a mock release run.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Note that we still get a file ending in \n from this, but the chomp() in MozBuild::Util::GetBuildIDFromFTP() will swallow that.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: The problem child

This is the state of win32_info.txt before I fixed it on stage and staging-stage.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 370565 [details] [diff] [review]
Use the bash environment on all platforms

This fixes up windows without breaking anything else in my mock release run.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 370565 [details] [diff] [review]
Use the bash environment on all platforms

committed changeset 242:317d6f8405ae

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

production-master:moz2-master reconfig'd.