486485 - crash [@ nsImapMailFolder::RenameClient(nsIMsgWindow*, nsIMsgFolder*, nsACString_internal const&, nsACString_internal const&) ]

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Ludovic Hirlimann [:Usul]]

0  	thunderbird.exe  	nsImapMailFolder::RenameClient  	nsImapMailFolder.cpp:7702
1 	thunderbird.exe 	nsImapIncomingServer::OnlineFolderRename 	nsImapIncomingServer.cpp:1407
2 	xpcom_core.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
3 	xpcom_core.dll 	nsEventQueue::GetEvent 	xpcom/threads/nsEventQueue.cpp:100
4 	xpcom_core.dll 	nsProxyObjectCallInfo::Run 	xpcom/proxy/src/nsProxyEvent.cpp:181
5 	xpcom_core.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:510
6 	xpcom_core.dll 	NS_ProcessNextEvent_P 	nsThreadUtils.cpp:227
7 	thunderbird.exe 	nsBaseAppShell::Run 	widget/src/xpwidgets/nsBaseAppShell.cpp:170
8 	thunderbird.exe 	nsAppStartup::Run 	toolkit/components/startup/src/nsAppStartup.cpp:192
9 	thunderbird.exe 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3279
10 	thunderbird.exe 	NS_internal_main 	nsMailApp.cpp:103
11 	thunderbird.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:87
12 	thunderbird.exe 	__tmainCRTStartup 	crtexe.c:591
13 	kernel32.dll 	kernel32.dll@0x8e3f2 	
14 	ntdll.dll 	ntdll.dll@0x7cfec 	
15 	ntdll.dll 	ntdll.dll@0x7d1fe

Comment 1

[Ludovic Hirlimann [:Usul]]

nominating for blocking so it get developer's attention .

More recent stack available at http://crash-stats.mozilla.com/report/index/a1a589e9-961b-48b7-9516-4d3382090722 for instance.

Comment 2

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/annotate/413d8929e05e/mailnews/imap/src/nsImapMailFolder.cpp#l7922

7919 nsCOMPtr<nsIMsgFolder> msgParent;
7920 msgFolder->GetParentMsgFolder(getter_AddRefs(msgParent));
7921 msgFolder->SetParent(nsnull);
7922 msgParent->PropagateDelete(msgFolder, PR_TRUE, nsnull);

Comment 3

[Wayne Mery (:wsmwk)]

3.0b3 topcrash. no comments in crashes

Comment 4

[David :Bienvenu]

Attachment: null check fix

I don't see this in b4pre, which might mean it's an uncommon crash. But it doesn't hurt to add a null check.

Comment 5

[David :Bienvenu]

fix checked in.