486513 - xulrunner 3.5/3.6 builds report to the Firefox3.5/Firefox tinderboxes

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

...and they really shouldn't. Historically, we've had a different tinderbox for XULRunner. Given that we're only doing nightly builds, I don't know if we *need* to report them somewhere, but it would be nice. We could probably just use the existing XULRunner tinderbox without moving the old/existing builds off of it.

Comment 1

[Aki Sasaki (not active)]

Looks like this is because they're placed into nightlyBuilders.

We could create a xulrunnerNightlyBuilders, or convert nightlyBuilders into a dictionary, or add a function that adds the builder to the appropriate place(s), with defaults that can be overridden (e.g. tinderboxTree).  It would seem that xulrunnerNightlyBuilders would be the solution closest to what we have now.

Comment 2

[Chris AtLee [:catlee]]

I don't know...I think they _should_ be reporting to the same trees as Firefox, since they share the same code.  But I don't feel super strongly about that...so -0 on this.

Comment 3

[Aki Sasaki (not active)]

future? wontfix? xulrunnerNightlyBuilders?

Comment 4

[[e-mail] (:bhearsum)]

If nobody is going to take it, future, I guess. Definitely not WONTFIX IMHO.

Comment 5

[Chris AtLee [:catlee]]

Attachment: Send xulrunner logs to XULRunner tinderbox

This patch should send production xulrunner builds to the XULRunner tree, and staging builds to MozillaTest.

Comment 6

[Aki Sasaki (not active)]

Dunno if you wanted review on that, but it looks good to me. The treename could go in config.py but it looks like we have tree names in master.cfg elsewhere as well.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I think we should move them to the XULRunner tree. There was a bustage in javaxpcom in the last 24 hours which was caught by having builds (great!), but that code's not built by Firefox so is effectively spurious red against mozilla-central tree (bad!).

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #7)
Filed bug 487960 on that bustage.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

XULRunner builds are hidden on the Firefox tree for now.

Comment 10

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Would landing this patch allow us to close this bug as FIXED? Or is there anything else to do here?

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

I'll get this landed today.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 371862 [details] [diff] [review]
Send xulrunner logs to XULRunner tinderbox

committed changeset 1091:314fe74857fb

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Aki did a reconfig on production-master:moz2-master at 15:05 PDT for this. I've started a Linux mozilla-1.9.1 build off and it has reported to the XULRunner tree. Scheduler looks good on the buildbot waterfall too. --> FIXED.

Thanks for the patch Chris!