486624 - AppendFacesFromFontFile is called twice for the same font file.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.8.0.4) Gecko/20060508 Firefox/3.0
Build Identifier: 

AppendFacesFromFontFile is called twice for the same font file becase FindFirstFileW is case-insensitive.

Reproducible: Always

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: A patch

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 370788 [details] [diff] [review]
A patch

the case sensitivity of FindFirstFile isn't actually documented (that I can find anyway).  So lets use FindFirstFileEx with 0 passed for dwAdditionalFlags which will specify case-insensitive. 

I'll r+ with that change, but I want to double check the arguments you pass to FindFirstFileEx, so r- for now.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Revised patch

Use FindFirstFileExW instead.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 371562 [details] [diff] [review]
Revised patch

requesting review from module owner

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/2fdf82e40fc7