486702 - Library left pane not updated properly / dynamically

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Open the Library
1. History - Show all History
2. In the right-pane - delete the 'today' folder
3. Note is disappears from the Left pane - Expected I would think
4. Now browse some and note that in the right pane the 'Today' folder is re-added showing your history, but the left pane does not have the 'Today' folder.
5. Close/reopen the History Library as in step 1, now you have the 'Today' folder.

Tested on Vista HP SP1 and today's nightly:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090403 Minefield/3.6a1pre Firefox/3.0.7 ID:20090403050211

Thanks to alice0755 in the builds forum:
http://forums.mozillazine.org/viewtopic.php?p=6168055#p6168055

Comment 1

[Alice0775 White]

The re-added 'Today' folder in the right pane can not expand by dblclick until reopen the the History Library.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

we were updating grouped queries only when they were roots, but in the left pane of the library they are simple children of a folder.

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 371351 [details] [diff] [review]
patch v1.0

r=me, thanks

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1.1

i simply added a null check on the observer, to be consistent with other observers (And because gc can do nice things to our no more used results)

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/8e2f94cd095d

Comment 6

[Jim Jeffery not reading bug-mail 1/2/11]

Verified fixed using hourly build: 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090408 Minefield/3.6a1pre Firefox/3.0.7 ID:20090408072231

Comment 7

[Marco Bonardo [:mak]]

pushed as a merged patch with bug 422163
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/969eb6567510

Comment 8

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090414 Shiretoko/3.5b4pre

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv