486707 - unable to search through the whole history in the Library

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Daniel.S]

In the Library, when you click on the top "History" item on the left side, you can't use the Library's search input field.
If you try, the search result will only show the folders "Today", "This month", etc.

I'd expect that in this case the search would look into all History containers, like it's done in the History sidebar or in the Library itself, when searching through all bookmarks on the "All Bookmarks" directory.

Comment 1

[Nochum Sossonko [:Natch]]

Placing on the blocking radar, this might land on 3.5 and that would be a serious usability regression...

Comment 2

[Drew Willcoxon :adw]

The problem you describe is a little vague.  Could you post the version of Firefox you're using, exact steps to reproduce, your expected results, and the precise actual results?

Comment 3

[Drew Willcoxon :adw]

Ah, I see it.  Marco, maybe a problem with bug 422163.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090403 Minefield/3.6a1pre

STR:
1. Open Places Library.
2. Click History in left pane.
3. Search for anything in the search box.

Actual results:
The containers "Today", "Last 7 days", "This month" appear in right content pane.

Expected results:
The history items that match my search should appear in the right content pane.

Problem not present in 20090402 nightly.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 371438 [details] [diff] [review]
patch v1.0


>     case "history":
>       if (currentOptions.queryType != Ci.nsINavHistoryQueryOptions.QUERY_TYPE_HISTORY) {
>         var query = PlacesUtils.history.getNewQuery();
>         query.searchTerms = filterString;
>         var options = currentOptions.clone();
>+        // Make sure we're getting uri results.
>+        options.resultType = currentOptions.RESULT_TYPE_URI;
>         options.queryType = Ci.nsINavHistoryQueryOptions.QUERY_TYPE_HISTORY;
>         content.load([query], options);
>       }

why not push this into applyFilter() as well?

r=me w/ this answered/addressed.

Comment 6

[Marco Bonardo [:mak]]

because when this happens we are searching through bookmarks, and the user asks to search through history, if we directly pass to applyFilter we will continue to search through bookmarks. And if we would set content.load and then call applyFilter we would execute the query 2 times, one with wrong resultType and one with correct one...
so better simply executing directly the correct query.

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/62f84feb3805

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

Verified fixed using hourly build: 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090408 Minefield/3.6a1pre Firefox/3.0.7 ID:20090408072231

Comment 9

[Marco Bonardo [:mak]]

pushed as a merged patch with bug 422163
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/969eb6567510

Comment 10

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre)
Gecko/20090414 Shiretoko/3.5b4pre

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv