Closed
Bug 486733
Opened 16 years ago
Closed 16 years ago
optimize/modernize Mac OS X toolkit/xre code
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(1 file, 2 obsolete files)
|
12.24 KB,
patch
|
Details | Diff | Splinter Review |
The Mac OS X code in toolkit/xre unnecessarily uses old and slow FSRef code. There are a bunch of unnecessary file system object conversions that hit the disk. It also reports old Carbon OSErr values for operations, we don't need that.
Attachment #370918 -
Flags: review?(mstange)
bump iid
Attachment #370918 -
Attachment is obsolete: true
Attachment #370937 -
Flags: review?(mstange)
Attachment #370918 -
Flags: review?(mstange)
|
||
Updated•16 years ago
|
Attachment #370937 -
Flags: review?(mstange) → review+
Attachment #370937 -
Flags: superreview?(benjamin)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 370937 [details] [diff] [review]
fix v1.1
>-[scriptable, uuid(7224E826-3F6C-4BB2-9C6E-02DA44575743)]
>+[scriptable, uuid(ECC00A13-68A9-4F92-B828-12BD322DC184)]
> interface nsILocalFileMac : nsILocalFile
This is a comment-only change and shouldn't need a UUID bump, I hope. r=me without it
Attachment #370937 -
Flags: superreview?(benjamin) → superreview+
gets rid of IID bump
Attachment #370937 -
Attachment is obsolete: true
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/adf251480d63
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 5•7 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•