486756 - Tryserver should run leak tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

I just got bit by failing leak tests on mozilla-central, it would be good if tryserver ran leak tests.

Comment 1

[Aki Sasaki (not active)]

I agree; there are a number of features and tests that would be good to get into Try, and leak tests would be among those.

We should get this functionality when we unify our try code with the rest of configs (bug 486567, which is targeted for this quarter), after which it will be more a matter of logistics (build machines, disk space, etc.)  Marking the dependency and futuring.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

We just got bit by this again:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1252965118.1252968638.24468.gz

Bug 486567 has been fixed so it would be good if this was higher priority then "Future"

Comment 4

[Jeff Muizelaar [:jrmuizel]]

And again:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1253821487.1253825353.14401.gz

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #3)
> We just got bit by this again:
> 
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1252965118.1252968638.24468.gz
> 
> Bug 486567 has been fixed so it would be good if this was higher priority then
> "Future"

Jeff: sorry, when bug#486567 was fixed, some related bugs were spun off, yet not marked as dependencies here. See bug#486567c17 for details. I've added them as blockers to this bug to help track.

The basic problem here is bringing TryServer code back in sync with what we run on the production masters. Once thats done, the new goodness in production masters should happen on TryServer: separate build from unittests, run unittests suites concurrently, be able to run unittest suites individually, run unittests on debug/release builds, etc, etc. And yes, leak tests too!

Comment 6

[Mike Shaver (:shaver emeritus)]

This bug is still Future, and the last estimate was for Q2, so I'm not sure what to expect in terms of timing.  (It sounds like the need is to make the try servers run the same code as the production servers, but that _also_ sounds like exactly like the summary of bug 486567, and is confirmed by my reading of comment 17.  Or are the leak tests related to packaged builds?)

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

The leak tests are not related to packaged bugs afaik, but this bug is now dependent on making tryserver to be another branch in config.py which is the 'new' way of doing things.  When that is turned on leak tests and packaged builds will all be included from the get go.  In terms of timing, this is a Q4 goal for me and I'm hoping to meet it.

Comment 8

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Try-as-branch is now live and does leak tests on builds. Closing.