Closed
Bug 48679
Opened 26 years ago
Closed 15 years ago
Convert tinderbox.mozilla.org to Tinderbox2 codebase.
Categories
(Webtools Graveyard :: Tinderbox2, defect, P3)
Webtools Graveyard
Tinderbox2
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: kberk.spamaway, Assigned: bear)
References
()
Details
Attachments
(1 file)
|
19.84 KB,
text/html
|
Details |
I don't think Ken Estes spent his time writing Tinderbox 2 to see it go untested
at Mozilla.org. I cannot speak for Ken, but I was under the impression that he
saw a need for code with more features that is easier to maintain. I therefore
suggest that Mozilla.org begin to migrate tinderbox.mozilla.org to Tinderbox2.
I suggest this first be done with the ports page and based on the experince from
that migration and on feedback from Tinderbox users (fix any appropriate bugs
etc.) that the main tinderbox page be migrated.
I am not a bonsai or tinderbox person, so exactly how much work is needed to
complete this migration, I don't know. I also realize that many of the
engineers at mozilla.org are feaverishly working toward the Mozilla 1.0 release
and the Netscape employees at Mozilla.org are working to commercial release.
However, rather than lose the support of an outside developer like Ken, I really
think some time should be spent getting the ball rolling on this project. The
code has been in the tree for 3 months now.
| Reporter | ||
Updated•26 years ago
|
Comment 1•26 years ago
|
||
yes, we should do this.
It would help if Ken got cvs access, Ken any status there?
There are a few forked versions of tinderbox outside of netscape,
it would be good to get back on track and fold in changes.
Moving from sendmail to HTTP post is one change I heard about.
OS: Windows 2000 → All
Hardware: PC → All
I got CVS access earlier this week. I updated tinderbox2 to the
latest version sorry no checkin comments yet, I just brought you up to
my current version, you will get checkin comments starting now.
I know nothing about any other work on tinderbox but the original code
(which I read to understand what it did) and my own code. What I am
offering is a radical redesign of tinderbox, more modular and more
'feature rich' it is now more of a "framework" then a product. The
code allows you to pick and choose which modules you wish to run with.
It is no longer monolithic. So some people have a replacment for
"processmail" which allows a HTTP post instead of using a MDA, I say
GREAT. More choices is what I have allowed to happen. There is a
clear interface for allowing tinderbox2 to "pickup" updates from any
update collection system. I want to expand the mail processing
subsystem to encompass more "push" technology from different sources.
I want both Bonsai and Bugzilla to push their data into tinderbox just
like the build machines do. However The choice of push/pull should be
optional. Currently Tinderbox pulls from Bonsai and we can allow this
as an option. Please look over my code. I have tried very hard to
keep the code readable and well documented. If you have any trouble
understanding the code then its a bug.
I think I can swing a trip to Netscape/Mozilla. I was thinking about
trying to get 2 weeks in California at the beginning of October. I
think this may help move the port along.
Ken Estes
I see that my trouble ticket:
38305
Convert tinderbox.mozilla.org to Tinderbox2 codebase.
blocks by trouble ticket:
18155
Tinderbox is not valid HTML. Fix tinderbox output to set an example.
I wish to point out that I run the output of all my scripts through
weblint to check for valid html. Also my tinderbox has two different
type of popup menus (with more possible) and the user can configure
what he sees. This means that netscape can continue using its style
sheet based popup menus while the rest of the world uses something
more portable.
Comment 4•26 years ago
|
||
so is this ready to set up and use? the last thing i heard about this work
was that some initial code was checked into a branch and i didn't think
anyone had worked on it since.
What's the name of the branch? (how do i check it out?) If everything
is working we should set this up somewhere. If Ken is coming to Mountain
View then that would be the perfect time to play with this.
I have been actively working on it.
It is ready to run, but some of the modules Netscape/Mozilla uses
need to be ported to the new architecture.
http://mozilla.org/tinderbox.html has compelete instructions for checkout
cvs checkout mozilla/webtools/tinderbox2
What is the next step here? Someone at Netscape/Mozilla
has to make a move. It has been a week and a half
since this ticket was opened and I have not seen tangable
progress or a plan.
The next step is for me to document current sheriff/comment settings and
request that they be available in tinderbox2 before it goes live.
The files as exposed to the world are documented in:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/webtools/tinderbox/README
See rev1.7:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&f
ile=README&root=/cvsroot&subdir=mozilla/webtools/tinderbox&command=DIFF_FRAMESE
T&rev1=1.6&rev2=1.7
Tinderbox implements the admin interface for the files in
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/webtools/tinderbox/admintree.
cgi
see rev 1.15
Thank you for working on this project and taking the time not to break things.
Also, please set up a test mozbot (or techbot
http://yoda.davidkrause.com/~timeless/techbot.pl.txt ) to verify that the
mozbot/techbot interfaces are still functional in tinderbox2
I assume by "sheriff/comment settings" you mean the files:
ignorebuilds.pl status.pl rules.pl sheriff.pl
These files are part of the new very flexible "TinderHeader" system.
please read the file src/lib/TinderHeader.pm to see how this works.
It is possible to allow different users of tinderbox to use different
implementations of "Headers". For example Netscape will use
TreeState_Bonsai.pm to query bonsai about the tree state but the rest
of the world may use TreeState.pm which stores the tree state in a flat
file. The Image (fortune) system (which is currently not implemented)
is just a special header. It is easy to add more headers if you need
them (rules/sheriff are not currently defined). Let me know what you
think of the current structure.
As for mozbot or techbot I am unsure what you are asking. Do these
programs really read the private datafiles of Tinderbox? I can not
support that. Currently I allow different "Persistence"
implementations. So the data may be saved either by Data::Dumper or
by Storable. If we want the bots to read a data file I will be happy
to make a new file for them to read, they just should not read
tinderboxes private databases. Another problem is that the private
databases may be moved around the file system and not stored near the
generated HTML. Here is a suggestion I will write a new file in the
generated HTML directories which is intended to be used by the
bots. This file will list ALL the headers and their values in some
easily parseable format.
Comment 10•26 years ago
|
||
status.pl sheriff.pl rules.pl simply split up the configurable
space at the top of tinderbox into 3 parts, and we chose to use
them in that way.
I believe the bots grab the sheriff.pl file, but this could
be changed to scrape the content for that information.
timeless was doing that before we put in sheriff.pl.
Comment 11•26 years ago
|
||
I thought this would be put off till ken came to visit but I guess that
won't be till october. How about if we set up a sandbox for this to
run as a test. This would let ken do all the work himself.
I'm not sure what all is needed to bet set up. The code could be at
http://webtools.mozilla.org/tinderbox2/ with a cron job set up to update
tinderbox2 code to the tip periodically, and search for all the aliases
with the word 'tinderbox' and create tidnerbox2 versions. Hopefully i can
direct copies of the normal tinderbox mail to tinderbox2 as well.
anything else?
Or, if mcaffee thinks this is ready to fly, then go for it.
One more thing, the other tinderbox tinderbox is confused by the
plus sign in Robert O'callahan's email address <roc+@someplace.org>.
Tinderbox gives a bad bonsai link for his checkins in the last N
hours. The url contains a plus sign instead of an escaped character
"%2B"?.
Is this also a bug in tinderbox2? How close is t2 to going live?
Should the bug be fixed in the original code?
Comment 12•26 years ago
|
||
> I believe the bots grab the sheriff.pl file, but this could be
> changed to scrape the content for that information. timeless was
> doing that before we put in sheriff.pl.
Not it is better to have the bots read a file then to have them assume
they can parse the HTML. I just do not want them reading the
tinderbox database files. I will create a special file for the bots.
> I thought this would be put off till ken came to visit but I guess
> that won't be till october.
So far there are no plans for a visit. My management has not approved
it and I can not really lobby for a trip until I can explain to them
what that will solve. What it really means is I need to see a bit of
progress at your end first.
> How close is t2 to going live?
I believe it is ready, baring minor bugs.
> How about if we set up a sandbox for this to run as a test. This
> would let ken do all the work himself.
I believe there is no work for me to do. You need to configure it to
your needs and run it.
> I'm not sure what all is needed to bet set up.
Why not run tinderbox2 in its own directory on some webserver. Take
the incoming mail for Tinderbox1 and have it send BOTH to the
tinderbox1 and tinderbox2 processmail programs. We can then run the
two programs in parallel and see how they differ. Tinderbox2 is only
the server end of things, I have not worked on the build scripts at
all.
> One more thing, the other tinderbox tinderbox is confused by the
> plus sign in Robert O'callahan's email address <roc+@someplace.org>.
> Tinderbox gives a bad bonsai link for his checkins in the last N
> hours. The url contains a plus sign instead of an escaped character
> "%2B"?.
I will ensure that this works in my code.
Comment 13•26 years ago
|
||
> the other tinderbox tinderbox is confused by the plus sign in
> Robert O'callahan's email address <roc+@someplace.org>.
Fixed in tinderbox2.
Comment 14•26 years ago
|
||
I think we should stage tinderbox2 somewhere and have it
running with tinderbox-1 for a while, then make the switch
when we think we are ready. Copying mail and sending to
both tinderboxes is a good idea, I also think we can get useful
information from setting up one or two builds that just point
to tinderbox2.
I started looking at this on Thursday, so far so good.
I will try to get this working on a local machine before
messing with mozilla.org machines. Dawn, we should set
up lounge to do tinderbox2 cgi's in a similar way that
tinderbox does it now.
Comment 15•26 years ago
|
||
test comment for kestes.
Updated•26 years ago
|
OS: FreeBSD → All
Hardware: Other → All
| Reporter | ||
Comment 17•25 years ago
|
||
Anyone know what the status of this bug is?
Comment 18•25 years ago
|
||
over to endico. I can provide background help, but
am out of time for this right now.
Assignee: mcafee → endico
Comment 19•25 years ago
|
||
lounge has many different versions of perl installed,
tinderbox2 install pulls things from the shell.
A wrapper needs to be written to set the environment to
find the right set of tools, (perl, etc.).
I posted a patch to abstract a few tools I needed,
patch was rejected.
Comment 20•24 years ago
|
||
I submitted a new patch for the configure script:
http://bugzilla.mozilla.org/show_bug.cgi?id=134312
The change lets you specify what version of perl you want on the command-line.
It defaults to use /usr/local/bin/perl is where perl should be. ;-)
Comment 21•24 years ago
|
||
ken estes to visit MV in April to help with the install on lounge,
send me mail for more info.
| Reporter | ||
Comment 23•23 years ago
|
||
I have not asked since this time in 2001, so does anyone know what the status of
this bug is?
I saw something about a possible Tinderbox 3 somewhere. Is this OBE, or has
Tinderbox 2 become the live tinderbox for mozilla.org and can this be resolved?
Comment 24•23 years ago
|
||
As of May, 2002, the tinderbox2 functionality was still missing critical
1.0 behavior that mozilla.org needs to make a tool switch in a production
environment. I asked Ken to test this on a server other than our
production server, and I never heard back. I'm not making this tools switch
until I see some tests happening somewhere else, and we keep enough 1.0
functionality to not rock the boat too much.
Comment 25•23 years ago
|
||
I do not have a publicly accessible web-server to
demonstrate the new code. So Demo-ing the code
for the benefit of the whole Netscape/Mozilla
community will be difficult.
I do have numerous unit tests which can be run to
test individual components and to test page
layout. So although I can test that the code
works, and the fact that I get patches from around
the world indicates that it works for others as
well. I still worry about isolating problems in
the Netscape/Mozilla environment. In the past
there were some unexpected mail problems and
problems with the way your build scripts report
time. I would not be surprised if there were
other interactions which I have not expected and
will be hard for me to isolate from home and I
suspect that you (Dawn, mcafee) would be too busy
to investigate any strange behaviors which arise.
Though I made much progress with the feature
requests while at Netscape I have been slow to
finish the features at home. I had just completed
work on a bunch of features when my drive crashed.
I am waiting to see what can be recovered. So my
tinderbox work is frozen for a week or so till I
understand what data has been lost.
As for tinderbox3 this may be easier for you all
to use since the authors are in house and would be
able to have direct access with any machines which
need investigation and with any user who wants a
new feature. I feel as if I am at a big
disadvantage, working on a core Netscape/Mozilla
tool and not being an employee.
I am posting a sample Tinderbox page which shows
off the new popup window code. This is a portable
flexible popup-window software which was donated
by one of my users. The page is a bit of a fake
concocted for use in a magazine article I am
writing. It gives the idea of how the popups work
and how the page will look but some of the layout
has been simplified to make the page easier to
understand. If you are interested I could post
more realistic pages generated by my test suites.
Comment 26•23 years ago
|
||
Here is a sample page showing off the new popup windows.
The code was not totally finished when my disk when down.
Also this page was generated for an article so is not totally
correct, but it gives a good idea of how I am thinking of making the
on click code work. I have to used the fudged page and gzip it
because the full HTML blows the attachment size limit for bugzilla.
Comment 27•23 years ago
|
||
Endico is no longer active in bugzilla, this bug needs a new owner.
Updated•20 years ago
|
QA Contact: timeless → tinderbox2
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Updated•12 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•