486793 - Unit tests: Add capability to easily profile a test

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I would like to be able to do something like:

  StartProfiling("MyTestcase");
  RunTestcase();
  StopProfiling();

Initially, I only care about Shark, but it should be easy to add support for other profilers that provide programmatic hooks.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Add StartProfiling() and StopProfiling() to TestHarness.h

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I used this patch to generate the profile in bug 456272.

Comment 3

[Benjamin Smedberg]

Comment on attachment 371002 [details] [diff] [review]
Add StartProfiling() and StopProfiling() to TestHarness.h

I'm a little unhappy about the makefile FLAGS changes, because they are localized to xpcom/tests, when TestHarness.h could/should be used other places. Can we just add those flags globally when shark is enabled?

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: v2

Moved setting of OS X framework flags to config.mk.

Comment 5

[Robert Sayre]

jsdbgapi.h has the same code... can we share?

Comment 6

[Benjamin Smedberg]

Sharing might be hard... they are in different build systems and are very difficult to link back together.

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed http://hg.mozilla.org/mozilla-central/rev/7be0087c83ca
Chris Jones - bug 486793: add programmatic control of profiler to xpcom unit tests. r=bsmedberg

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Copy it to comm-central [Checkin: Comment 9]

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 426902 [details] [diff] [review]
(Bv1-CC) Copy it to comm-central
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/36643bb71021

I wonder how this patch ended up with "From: Paolo Amadini ..." :-/