Closed
Bug 486793
Opened 12 years ago
Closed 12 years ago
Unit tests: Add capability to easily profile a test
Categories
(Core :: XPCOM, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(2 files, 1 obsolete file)
5.65 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
1009 bytes,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
I would like to be able to do something like: StartProfiling("MyTestcase"); RunTestcase(); StopProfiling(); Initially, I only care about Shark, but it should be easy to add support for other profilers that provide programmatic hooks.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #371002 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•12 years ago
|
||
I used this patch to generate the profile in bug 456272.
Updated•12 years ago
|
Attachment #371002 -
Flags: review?(benjamin) → review-
Comment 3•12 years ago
|
||
Comment on attachment 371002 [details] [diff] [review] Add StartProfiling() and StopProfiling() to TestHarness.h I'm a little unhappy about the makefile FLAGS changes, because they are localized to xpcom/tests, when TestHarness.h could/should be used other places. Can we just add those flags globally when shark is enabled?
Assignee | ||
Comment 4•12 years ago
|
||
Moved setting of OS X framework flags to config.mk.
Attachment #371002 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #371949 -
Flags: review?(benjamin)
Updated•12 years ago
|
Attachment #371949 -
Flags: review?(benjamin) → review+
Comment 5•12 years ago
|
||
jsdbgapi.h has the same code... can we share?
Comment 6•12 years ago
|
||
Sharing might be hard... they are in different build systems and are very difficult to link back together.
Assignee | ||
Comment 7•12 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/7be0087c83ca Chris Jones - bug 486793: add programmatic control of profiler to xpcom unit tests. r=bsmedberg
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Comment 8•11 years ago
|
||
Attachment #426902 -
Flags: review?(bugspam.Callek)
Updated•11 years ago
|
Attachment #426902 -
Flags: review?(bugspam.Callek) → review+
Comment 9•11 years ago
|
||
Comment on attachment 426902 [details] [diff] [review] (Bv1-CC) Copy it to comm-central [Checkin: Comment 9] http://hg.mozilla.org/comm-central/rev/36643bb71021 I wonder how this patch ended up with "From: Paolo Amadini ..." :-/
Attachment #426902 -
Attachment description: (Bv1-CC) Copy it to comm-central → (Bv1-CC) Copy it to comm-central
[Checkin: Comment 9]
Updated•11 years ago
|
Blocks: C192ConfSync
You need to log in
before you can comment on or make changes to this bug.
Description
•