486866 - [silme] self._getPos should be self._get_pos in L10nObject.add_elements()

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Staś Małolepszy :stas]

What summary says.

Plus, just for the sake of readability I'd also suggest using
  if pos:
instead of:
  if not pos == None:
line above. They're equal, right?

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to comment #0)
> What summary says.

Fixed, http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/23d0b935550e

> Plus, just for the sake of readability I'd also suggest using
>   if pos:
> instead of:
>   if not pos == None:
> line above. They're equal, right?

Nah,

if pos:
  ...

catches pos=0 case.

Comment 2

[Staś Małolepszy :stas]

Oh, right. Didn't think of that. 

Thanks for landing the patch.