Closed Bug 486866 Opened 15 years ago Closed 15 years ago

[silme] self._getPos should be self._get_pos in L10nObject.add_elements()

Categories

(Mozilla Localizations :: Infrastructure, defect)

Product:
Mozilla Localizations
Component:
Infrastructure
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: stas, Assigned: zbraniecki)

Details

What summary says.

Plus, just for the sake of readability I'd also suggest using
  if pos:
instead of:
  if not pos == None:
line above. They're equal, right?
(In reply to comment #0)
> What summary says.

Fixed, http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/23d0b935550e

> Plus, just for the sake of readability I'd also suggest using
>   if pos:
> instead of:
>   if not pos == None:
> line above. They're equal, right?

Nah,

if pos:
  ...

catches pos=0 case.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee: nobody → gandalf
Oh, right. Didn't think of that. 

Thanks for landing the patch.
You need to log in before you can comment on or make changes to this bug.