486924 - Crash due to too much recursion through PresShell::ProcessReflowCommands

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Florian Quèze [:florian]]

Attachment: Stack of the crash from the Apple crash reporter (with a debug build)

See attached stack.

I think this crash happens when my JS code adds hundreds of items to a listbox.
I don't know the exact regression range. The first time I noticed it was with a build built 2 days ago, so I guess it's somewhere between 2 days and a week.

I also noticed that some listbox items are not visible. For example, I have 7 profiles and the profile manager displays only 4 of them, however the scroll bar is displayed with the right size (the scrollheight is big enough to display the 7 items).

Comment 1

[Nochum Sossonko [:Natch]]

This is basically a dupe of bug 486848, only there was no mention of a crash. I'll mark as dependent for now.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm.  It's not clear to me that this is a dup of bug 486848.  This bug is an infinite recursion causing stack overflow (so the signature in the summary is pointless).

The issue in bug 486848 _may_ cause that.  But I don't see why, and we should be guarding against this in any case. So no matter what happens with this bug, we'll want a separate fix here, imo.

Comment 3

[Boris Zbarsky [:bzbarsky]]

In any case, this bug needs a testcase; per comment 0 there's one around _somewhere_.

Comment 4

[Florian Quèze [:florian]]

I just tried to rebuild with the patch attached to bug 486848 and both the issue with the profile manager and the crash disapeared.

Comment 5

[Florian Quèze [:florian]]

(In reply to comment #3)
> In any case, this bug needs a testcase; per comment 0 there's one around
> _somewhere_.

The crash happens with the last two Mac (haven't tested the other OSes) nightlies of Instantbird when I join #developers, while the code populates the list of people in the chat room.
I'm not sure how easy or hard it would be to produce a reduced testcase. I suspect the crash depends on the nicknames of people in the room because I joined other chat rooms with as many people and didn't crash there.

Comment 6

[Daniel Veditz [:dveditz]]

Florian: Did the patch in bug 486848 fix this or is it still happening?

Comment 7

[Florian Quèze [:florian]]

The patch of bug 486848 made the crash disappear so I'm tempted to say this bug is fixed, but comment 2 suggests that there is probably something more to do/fix here.

Comment 8

[Jesse Ruderman]

bz, please file a new bug based on the issue you identified in comment 2.

Comment 9

[Boris Zbarsky [:bzbarsky]]

I can't recall what that issue was now, honestly....