486925 - nsIconChannel calls gnome_init_*() too late

Status: NEW

(Firefox :: File Handling, defect)

Description

[Tomeu Vizoso]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.8) Gecko/2009032711 Ubuntu/8.10 (intrepid) Firefox/3.0.8
Build Identifier: 

Per the docs, gnome_init_*() should be called as early as possible.

Currently, nsIconChannel initializes the gnome program structure only when it needs it, which is probably far too late. In the case of Sugar, it caused the browsing activity to lock up, trying to initialize a second, redundant, XSMP session.

Instead of lazily initializing gnome, I think it should raise an assertion if it needs gnome to be initialized but it isn't yet.

Though maybe the right fix would be to move to GIO (#402892) and drop the dependencies on gnome* libs.

Reproducible: Always

Comment 1

[Arpad Borsos [:Swatinem]]

I've done a patch in bug 467168 to replace the gnomevfs usage in nsIconChannel.
Haven't requested review yet as the patch is quite hacky and the dependencies don't work out anyway.

Comment 2

[Tomeu Vizoso]

(In reply to comment #1)
> I've done a patch in bug 467168 to replace the gnomevfs usage in nsIconChannel.
> Haven't requested review yet as the patch is quite hacky and the dependencies
> don't work out anyway.

Your patch seems to make nsIconChannel much less hacky to me.