Open Bug 486925 Opened 15 years ago Updated 2 years ago

nsIconChannel calls gnome_init_*() too late

Categories

(Firefox :: File Handling, defect)

x86
Linux
defect

Tracking

()

People

(Reporter: tomeu, Unassigned)

References

Details

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.8) Gecko/2009032711 Ubuntu/8.10 (intrepid) Firefox/3.0.8
Build Identifier: 

Per the docs, gnome_init_*() should be called as early as possible.

Currently, nsIconChannel initializes the gnome program structure only when it needs it, which is probably far too late. In the case of Sugar, it caused the browsing activity to lock up, trying to initialize a second, redundant, XSMP session.

Instead of lazily initializing gnome, I think it should raise an assertion if it needs gnome to be initialized but it isn't yet.

Though maybe the right fix would be to move to GIO (#402892) and drop the dependencies on gnome* libs.

Reproducible: Always
I've done a patch in bug 467168 to replace the gnomevfs usage in nsIconChannel.
Haven't requested review yet as the patch is quite hacky and the dependencies don't work out anyway.
Status: UNCONFIRMED → NEW
Depends on: 467168
Ever confirmed: true
(In reply to comment #1)
> I've done a patch in bug 467168 to replace the gnomevfs usage in nsIconChannel.
> Haven't requested review yet as the patch is quite hacky and the dependencies
> don't work out anyway.

Your patch seems to make nsIconChannel much less hacky to me.
Blocks: 225148
Product: Core → Firefox
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.