487104 - GCThreadLocal needs to be VMPI-ized

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Rishit Shah]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; .NET CLR 3.5.30729; .NET CLR 3.0.30618)
Build Identifier: 

GCThreadLocal class uses Win32/Posix APIs for implementing TLS.  In the spirit of porting, we need replace these with appropriate VMPI APIs.

Reproducible: Always

Comment 1

[Rishit Shah]

Attachment: [v1] patch

Comment 2

[Tommy Reilly]

Comment on attachment 372422 [details] [diff] [review]
[v1] patch

I think we shouldn't compile (or not link) if someone tries to compile ThreadsPosix and there's no pthreads, the default impl provided here is just broken.

Comment 3

[Rishit Shah]

So just get rid of the default implementation?

Comment 4

[Rishit Shah]

Also, I think that vmpi_tls_id_t is unnecessary.  I intend to replace that with uintptr_t in the APIs.

Comment 5

[Tommy Reilly]

Comment on attachment 372422 [details] [diff] [review]
[v1] patch

+ with the default unix impl taken out

Comment 6

[Tommy Reilly]

actually I take that back, there seems to be some missing manifest file updates for the xp build system

Comment 7

[Rishit Shah]

I have added ThreadsWin.cpp to VMPI/manifest.mk

Comment 8

[Tommy Reilly]

doh, not sure how I missed that...

Comment 9

[Rishit Shah]

changeset 1763	052befa27baf