487160 - build fails with --enable-libnotify after bug 423756 landed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Takeshi Kurosawa :takenspc]

After bug 423756 landed, I get the compile error like below. This only happens with --enable-libnotify (nsAlertsIconListener.cpp is compiled when libnotify support is enabled).

c++ -o nsAlertsIconListener.o -c -I../../../dist/include/system_wrappers -include /media/disk/mozilla/src/hg/mozilla/config/gcc_hidden.h -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I/media/disk/mozilla/src/hg/mozilla/toolkit/components/build/ -I/media/disk/mozilla/src/hg/mozilla/toolkit/system/gnome -I. -I../../../dist/include/xpcom -I../../../dist/include/string -I../../../dist/include/necko -I../../../dist/include/alerts -I../../../dist/include/gfx -I../../../dist/include/imglib2 -I../../../dist/include/intl -I../../../dist/include/widget -I../../../dist/include   -I../../../dist/include/mozgnome -I/media/disk/mozilla/src/hg/obj-i686-pc-linux-gnu/dist/include/nspr     -I/media/disk/mozilla/src/hg/obj-i686-pc-linux-gnu/dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions -finline-limit=50 -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -pthread -DORBIT2=1 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gnome-vfs-module-2.0   -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/local/include/cairo -I/usr/local/include -I/usr/local/include/pixman-1 -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12      -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsAlertsIconListener.pp /media/disk/mozilla/src/hg/mozilla/toolkit/system/gnome/nsAlertsIconListener.cpp
In file included from /media/disk/mozilla/src/hg/mozilla/toolkit/system/gnome/nsAlertsIconListener.cpp:42:
../../../dist/include/gfx/nsIImage.h:44:24: error: gfxPattern.h: No such file or directory
In file included from /media/disk/mozilla/src/hg/mozilla/toolkit/system/gnome/nsAlertsIconListener.cpp:42:
../../../dist/include/gfx/nsIImage.h:215: error: 'gfxPattern' has not been declared
../../../dist/include/gfx/nsIImage.h:215: error: expected ',' or '...' before 'aFilter'
../../../dist/include/gfx/nsIImage.h:285: error: 'gfxPattern' has not been declared
make[4]: *** [nsAlertsIconListener.o] Error 1

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Patch

Add thebes to REQUIRES when libnotify support is enabled.

Comment 3

[Takeshi Kurosawa :takenspc]

I forgot to add "checkin-needed" to Keywords.
# or do I need to request the super-review?

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/58ebf31e5c39