Open Bug 487206 Opened 17 years ago Updated 3 years ago

Revise Text for "Accept" button in Provider Uninstall Dialog

Categories

(Calendar :: Calendar Frontend, enhancement)

enhancement

Tracking

(Not tracked)

People

(Reporter: dbo, Unassigned, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

If I am disabling the pdata-provider, I am asked for the calendars to be unsubscribed. Nevertheless I only want to temporarily disable the provider (without unsubscribing any calendar), I need to press the button "Unsubscribe" which looks odd. Suggestion: Change the label to "Unsubscribe" if a calendar has been selected, else stay with "Ok".
OS: Mac OS X → All
Hardware: x86 → All
Component: Provider: GData → Calendar Views
QA Contact: gdata-provider → views
Summary: Disabling gdata-provider: unsubscribe dialog → Revise Text for "Accept" button in Provider Uninstall Dialog
Also, there are two currently unused strings that I forgot to hook up. I suggest to change the buttons as follows: When a calendar is selected: [ Keep Addon ] [ Unsubscribe ] When no calendars are selected [ Keep Addon ] [ Continue ]
Whiteboard: [good first bug][mentor=Fallen][lang=js]
Mentor: philipp
Whiteboard: [good first bug][mentor=Fallen][lang=js] → [good first bug][lang=js]
Hello, I would like to work on this if I could have a look at the relevant code please? Thanks.
Hi Aaron, thanks for looking into this. The code for the dialog is here: http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-providerUninstall-dialog.js http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-providerUninstall-dialog.xul You can trigger the dialog by installing the Provider for Google Calendar, adding a few calendars, then uninstalling the provider. MXR can also be used to find the localization files. When you change a localization string you need to also change the key name of the string. There is also the difference between .dtd and .properties files. The former is just for strings in .xul files, the other can be used if you need to switch the strings dynamically. From reading above comments only, in this bug you should change the strings and add some logic do switch the strings if no calendar is selected. If you need ad-hoc help feel free to contact me on irc.mozilla.org #calendar, my nickname is Fallen.
Assignee: nobody → aaronjlaw
Status: NEW → ASSIGNED
Hello, I have made some changes for this but I am just wondering where I need to create the logic to switch the statements if there are no calendars selected etc.
Flags: needinfo?(philipp)
Answered this needinfo via email.
Flags: needinfo?(philipp)
Assignee: aaronjlaw → nobody
Status: ASSIGNED → NEW
If nobody is working on this bug, can it be assigned to me? I would like to work on it.
Please do! Let me know if you have questions on how to get started, the previous comments should already be helpful.
Assignee: nobody → sakshivaid95
Keywords: good-first-bug
Whiteboard: [good first bug][lang=js] → [lang=js]
Assignee: sakshivaid95 → nobody

Hello, I am new to contributing to Bugzilla can you assigned me to this issue so that I can learn to fix these bugs and also suggest to me how can Is start working on this bug to fix it.

Severity: normal → S3

Hi, I am an outreachy applicant and I would be much grateful if I can be guided to fix this bug

Hey, Ayesha here(an Outreachy applicant). I wanna work on this project. Can you assign it to me?

Hi, If anybody is not working on this bug then please assign it to me. And if that is the case then mentors please also guide to fix it.

You need to log in before you can comment on or make changes to this bug.