Closed Bug 487224 Opened 15 years ago Closed 15 years ago

add testcases to test shell debug cli

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: dschaffe, Assigned: dschaffe)

Details

Attachments

(1 file)

patch
4.50 KB, patch
rreitmai
: review+
Details | Diff | Splinter Review 
add testcases to cover implemented debug cli commands:
b(ack)t(race), s(tep), n(ext), f(inish),c(ontinue),l(ist),b(reakpont),d(elete), s(et)

to run testsuite:
export AVM=<path to avmshell>
export AVMRD=<path to debugger avmshell>
cd tamarin-redux/test/cmdline
./runtests.py


Running the cmdline tests with code coverage I get 86% method coverage in DebugCLI.cpp and 100% DebugCLI.h.  Not covered in DebugCLI.cpp are: 
DebugCLI::~DebugCLI (quit is not calling the destructor?)
DebugCLI::print() (not implemented yet)
 DebugCLI::commandNumberToCommandName() - not sure what this is
Flags: flashplayer-triage+
Attached patch patch — — Splinter Review 
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED

        Attachment #371458 -
        Flags: review?(rreitmai)

    
  

        Attachment #371458 -
        Flags: review?(rreitmai) → review+

    
    

    
  
fixed in changeset 1745	b10a458e4b95 4/13/2009
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
closing bug by marking verified/fixed.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: