487234 - Strip headers from packaged frameworks

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

All of our 3rd-party frameworks have headers in them, which are useless to ship. We should run a final pass over Camino.app in our build that nukes the headers.

Comment 1

[Stuart Morgan]

Attachment: fix

Every ~100 KB helps!

Comment 2

[Mark Mentovai]

Comment on attachment 374621 [details] [diff] [review]
fix

sr=me with changes.

>Index: Camino.xcodeproj/project.pbxproj

> 				3F44AF9405BDFBA000CB4B08 /* Frameworks */,

I would do this for both app targets, not just the static one.

>Index: scripts/strip-headers.sh

>+find "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}" -name *.h -exec rm {} \;

I mighta left this out and done "rm -rf" instead of "rmdir" on the directory removal.

>+find "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}" -name Headers -type l -exec rm {} \;
>+find "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}" -name Headers -type d -exec rmdir {} \; -prune

You should look for PrivateHeaders in addition to Headers.

IM me if you want me to look at another round.

Comment 3

[Stuart Morgan]

(In reply to comment #2)
> I would do this for both app targets, not just the static one.

Done (I went back and forth on that myself)

> I mighta left this out and done "rm -rf" instead of "rmdir" on the directory
> removal.

Per IM discussion, I lack mento's cast-iron stomach, but we worked out a compromise involving failing if an rmdir fails.

> You should look for PrivateHeaders in addition to Headers.

Done.

Landed on cvs trunk with those changes.