487254 - sftkmod.c uses POSIX file IO Functions on WinCE, which doesn't have them

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[John Wolfe (:wolfe)]

Attachment: v1.0 patch in HG format

In security/nss/lib/softoken/sftkmod.c - POSIX file IO operations are used.

Since WINCE has no POSIX file operations, the lfopen function needs to be replaced with a simple fopen() function call.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

this appears to be from bug 463452

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 371487 [details] [diff] [review]
v1.0 patch in HG format


>-    fd = lfopen(dbname, "a+", O_CREAT|O_RDWR|O_APPEND);
>+#ifdef WINCE
>+    fd = fopen(dbname, "a+");
>+#else
>+    fd = lfopen(dbname, "a+",   O_CREAT|O_RDWR|O_APPEND);
>+#endif
>     if (fd == NULL) {
>     return SECFailure;
>     }

nit, fix ws

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 371487 [details] [diff] [review]
v1.0 patch in HG format

r=nelson, with whitespace of the lfopen line restored to same 
as before the patch.

>-    fd = lfopen(dbname, "a+", O_CREAT|O_RDWR|O_APPEND);
>+    fd = lfopen(dbname, "a+",   O_CREAT|O_RDWR|O_APPEND);

Now, who's going to do these commits?
Bob, Kai, me?

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Checking in util/nssutil.h;     new revision: 1.3;  previous revision: 1.2
Checking in softoken/sdb.c;     new revision: 1.12; previous revision: 1.11
Checking in softoken/sftkmod.c; new revision: 1.5;  previous revision: 1.4

Comment 5

[Wan-Teh Chang]

Attachment: Define lfopen as a macro for WINCE

This alterative patch reduces the number of ifdefs.