487255 - sdb.c uses POSIX file IO Functions on WinCE, which doesn't have them

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[John Wolfe (:wolfe)]

Attachment: v1.0 patch in HG format

WinCE has not POSIX File IO functions, and has no "chmod" function - since file attributes are handled differently from LINUX systems.

security/nss.lib/softoken/sdb.c calls the "chmod() function API.

This call to chmod needs to be #ifdef'ed out of WinCE builds, or we receive a "function not found" error during linking nss3.dll

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

this appears to be from bug 463452

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 371488 [details] [diff] [review]
v1.0 patch in HG format

John, please request review from NSS peers.  
Thanks.

Comment 3

[Robert Relyea]

Comment on attachment 371488 [details] [diff] [review]
v1.0 patch in HG format

r+ rrelyea

Comment 4

[Robert Relyea]

I presume Jon will need an NSS team member to check this in.

bob

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Yes, please do the checkins for all today's new WinCE bugs.

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Checking in util/nssutil.h;     new revision: 1.3;  previous revision: 1.2
Checking in softoken/sdb.c;     new revision: 1.12; previous revision: 1.11
Checking in softoken/sftkmod.c; new revision: 1.5;  previous revision: 1.4