Closed
Bug 48736
Opened 26 years ago
Closed 26 years ago
[MLK] Leaking form HTTP headers
Categories
(Core :: DOM: Core & HTML, defect, P3)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
People
(Reporter: beard, Assigned: pollmann)
References
()
Details
(Keywords: memory-leak, Whiteboard: [nsbeta3+] fix in hand)
Call to ToNewCString(), result is passed to NS_NewPostDataStream(), which copies
it, so string leaks.
Keywords: mlk
|
Reporter | |
Comment 2•26 years ago
|
||
Nominating for nsbeta3, as this leak will occur with every form submission.
Keywords: nsbeta3
|
|
Assignee | |
Comment 3•26 years ago
|
||
Looks like the post buffer is cleaned up only in the failure case:
915 if (NS_OK != rv) {
916 delete [] postBuffer;
917 }
The fix is trivial and small, suggest nsbeta3+.
Status: NEW → ASSIGNED
|
|
||
Updated•26 years ago
|
Whiteboard: [nsbeta3+]
|
|
||
Comment 4•26 years ago
|
||
Marking nsbeta3+
|
|
Assignee | |
Updated•26 years ago
|
Whiteboard: [nsbeta3+] → [nsbeta3+] fix in hand
|
|
Assignee | |
Comment 5•26 years ago
|
||
Fix checked in.
There is no way to verify this fix by running the program. To verify by looking
at the code, look here:
http://lxr.mozilla.org/seamonkey/source/layout/html/forms/src/nsFormFrame.cpp#890
Before this was a char* that was only deleted in some cases.
Now it is an nsCAutoString, which is automatically deleted on destruction.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•26 years ago
|
||
Per Pollmann's comments:
Marking VERIFIED FIXED on:
- LinuxRH62 2000-09-08-08-M18 Commercial
- Win98 2000-09-08-08-M18 Mozilla
- MacOS86 2000-09-07-04-M18 Commercial
Status: RESOLVED → VERIFIED
|
||
Updated•7 years ago
|
Component: HTML: Form Submission → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•