Allow possibility for alternate shutdown methods, e.g. clean quit of application

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
10 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 1 bug)

Dependency tree / graph

Details

(Whiteboard: [mozmill-1.2])

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 371648 [details] [diff] [review]
Proposed fix

When a test finished, the MozMill CLI class just calls to the runner and tells it to stop, killing the application.

This isn't very useful when we want to run leak tests alongside UI testing - e.g. if I run this set of tests, does it leak?

Given we haven't really got a generic shutdown method, I'm proposing that we provide a new function 'stop_runner' in the MozMill class, and have the CLI class call to that.

We can then sub-class MozMill and override that function to provide more complex shutdown functions.

Proposed fix attached, I've tested this locally on my Thunderbird tests and it seems to be working fine.
(Assignee)

Updated

10 years ago
Blocks: 458352
(Assignee)

Comment 1

10 years ago
This is P1 for Thunderbird - we really need it for running mozmill in bloat tests which is one of our main priorities at the moment (so we can start expanding them).

Also, we're likely to spin our own test controllers (depending on if the restart test structure does what we need), and if we do we want to be able to cleanly shutdown so that we can do further leak tests on specific test runs.

The good news is that I've already proposed a patch for this...
Priority: -- → P1
Whiteboard: [mozmill-1.2]
We had already added some code to the mozmill restart tests to shut down cleanly using the quit menu.

I've generalized that code a bit better and now when running tests we default to "cleanQuit".

Fixed in r439
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.