487430 - Crash: [@ call_enumerate ] in js/src/jsfun.cpp:754 when Javascript Debugger window opened.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Michael Kraft [:morac]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090408 Firefox/3.5b4pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090408 Firefox/3.5b4pre

Starting with the 20090407 trunk load, when the Javascript Debugger (0.9.87.0) window is opened, Minefield crashes.

Reproducible: Always

Steps to Reproduce:
1. Install Javascript Debugger add-on
2. Open Debugger window 

Actual Results:  
Minefield crashes.

Expected Results:  
Minefield should not crash.


http://crash-stats.mozilla.com/report/index/5255e7ab-712d-4b8b-844a-1f54a2090408?p=1
http://crash-stats.mozilla.com/report/index/c0e3880b-68b8-4979-a0a2-127dd2090408?p=1

Comment 1

[timeless]

bug 452598 touched this function a few days ago.

could you possibly bisect the crash? (i.e. try a build from 2 weeks ago, then a build from either 1 or 4 weeks ago ...)

Comment 2

[Michael Kraft [:morac]]

Like I mentioned in comment #0, the problem started with the 20090407 trunk load.  It was fine before then.

I have a 2nd computer that does not crash when the Javascript Debugger window opens, but on that computer the Java plugin activates when the Javascript Debugger window opens (java.exe runs).  On the computer that crashes, Java never ran when the Javascript Debugger window opened.  I don't know if that's relative or not.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

The comment says it all -- I don't know how to make an automated test for this that doesn't involve the dbg api.

Comment 4

[Michael Kraft [:morac]]

I don't know if this is relevant or not, but on the computer that crashes, I'm not running as an administrator and the computer itself runs a hyperthreading processor.  It also has an older version of java on it which may or may not be relevant since that computer does not load java when the debugger is started.
 
The computer that does not crash does not have a hyperthreading processor (one core) and I run as an administrator.  This computer has an up to date java, which loads when the debugger window is opened (even in Firefox 3.0.8 for some reason).

Also sometimes the browser doesn't crash when the Javascript debugger window opens, until I click back on the opening window.

Comment 5

[timeless]

from the code fix, it isn't related to threading. fwiw, we don't need feedback from you until a nightly includes it.

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 372535 [details] [diff] [review]
Proposed fix

Thanks,

/be

Comment 7

[Michael Kraft [:morac]]

I know you said you don't need feedback from me, but since the 1.9.1? blocking flag was set, I'll mention that I'm not seeing this crash in the 1.9.1 nightly loads.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/e6b3463919b4

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/e6b3463919b4

Comment 10

[Michael Kraft [:morac]]

The nightly trunk load is no longer crashing so it looks like the fix worked.

Comment 11

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9a8b99104f1e

Comment 12

[Aakash Desai [:aakashd]]

Just adding this in for a future verifier: 

verification is dependent on javascript debugger being compatible with minfield shiretoko nightlies (or 3.5b4 release).

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not worth checking for a regression range for an already fixed bug.