Closed Bug 487484 Opened 17 years ago Closed 16 years ago

refactor trampoline management code to cleanly support different policies

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 563119
Future

People

(Reporter: edwsmith, Unassigned)

References

Details

Attachments

(1 file)

code for dealing with invocation trampolines is all over the place. Consolodate it so we can cleanly separate different policies. 1. interp-only - verify first, then interpret forever 2. interp+jit - verify first, then interp or jit based on static heuristic (current policy) (wordcode + abc variants included) 3. interp first, jit 2nd and later calls etc
First try, ready for style review, but not quite ready to land. I want to use the refactoring to add new policy, before actually landing the refactoring.
Assignee: nobody → edwsmith
step in the right direction. Although one nit is the naming of Trampoline functions initXXX(). Can we use some other verb besides init? How about 'bindTo' or 'target' ?
which method offends? initMethodEnv() and initMethodInfo() are aptly named because they initialize the trampoline to an initial state. initInterface() could be renamed. I'll add comments at least clarifying the contract. the names make more sense once you know the context.
Agreed, but for example at first glace initMethodEnv() implies (rightly or wrongly) initialization of MethodEnv which is not the case. Of course after looking at the code, its clear what's going on, but it might be easily avoided by not using the init moniker.
Target Milestone: --- → Future
Assignee: edwsmith → nobody
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
bulk verifying resolved !fixed issues
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: