Closed
Bug 487484
Opened 17 years ago
Closed 16 years ago
refactor trampoline management code to cleanly support different policies
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
DUPLICATE
of bug 563119
Future
People
(Reporter: edwsmith, Unassigned)
References
Details
Attachments
(1 file)
|
98.04 KB,
patch
|
Details | Diff | Splinter Review |
code for dealing with invocation trampolines is all over the place. Consolodate it so we can cleanly separate different policies.
1. interp-only - verify first, then interpret forever
2. interp+jit - verify first, then interp or jit based on static heuristic (current policy)
(wordcode + abc variants included)
3. interp first, jit 2nd and later calls
etc
| Reporter | ||
Comment 1•17 years ago
|
||
First try, ready for style review, but not quite ready to land. I want to use the refactoring to add new policy, before actually landing the refactoring.
Assignee: nobody → edwsmith
Comment 2•17 years ago
|
||
step in the right direction. Although one nit is the naming of Trampoline functions initXXX(). Can we use some other verb besides init? How about 'bindTo' or 'target' ?
| Reporter | ||
Comment 3•17 years ago
|
||
which method offends? initMethodEnv() and initMethodInfo() are aptly named because they initialize the trampoline to an initial state. initInterface() could be renamed.
I'll add comments at least clarifying the contract. the names make more sense once you know the context.
Comment 4•17 years ago
|
||
Agreed, but for example at first glace initMethodEnv() implies (rightly or wrongly) initialization of MethodEnv which is not the case.
Of course after looking at the code, its clear what's going on, but it might be easily avoided by not using the init moniker.
Updated•17 years ago
|
Target Milestone: --- → Future
| Reporter | ||
Updated•16 years ago
|
Assignee: edwsmith → nobody
| Reporter | ||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•