Closed Bug 487518 Opened 14 years ago Closed 14 years ago

Search widget on OS X shouldn't start search when clicking on non-existent search icon

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Version:
1.9.1 Branch
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: whimboo, Assigned: dao)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

patch
778 bytes, patch
enndeakin
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090408 Shiretoko/3.5b4pre ID:20090408030745

With the change on bug 450800 we support the native look for the search widget on OS X with only a magnifying glass on the left side. There is none on the right side like on other platforms. So clicking on the icon deck shouldn't trigger the search on OS X. Only pressing Enter should do this.

We should only remove the event handler for the search icon deck but still handle it when the clear icon is displayed.
Component: XUL Widgets → Themes
QA Contact: xul.widgets → themes
Attached patch patch — — Splinter Review 
Assignee: nobody → dao

        Attachment #371809 -
        Flags: review?(enndeakin)
Status: NEW → ASSIGNED

    
  

        Attachment #371809 -
        Flags: review?(enndeakin) → review+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/4b1f5eb29671
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1

    
  

        Attachment #371809 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 371809 [details] [diff] [review]
patch

a191=beltzner

        Attachment #371809 -
        Flags: approval1.9.1? → approval1.9.1+

    
  
Keywords: checkin-needed

    
    

    
  
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090415 Minefield/3.6a1pre ID:20090415030845
Status: RESOLVED → VERIFIED

    
    

    
  
Verified fixed on 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5;
en-US; rv:1.9.1b4pre) Gecko/20090416 Shiretoko/3.5b4pre ID:20090416030924.

Dao, it's bad that we would not be able to detect a regression on OS X with your written test for the search widget. Clicking on the searchIcon while the search widget is in searchButton mode shouldn't trigger a search. Can we integrate it into the test?
Flags: in-testsuite?
Keywords: fixed1.9.1 → verified1.9.1

    
    

    
  
No. The test is there to test the toolkit binding, which needs to work consistently across platforms.

    
    

    
  
Means no automated test is possible and we need a manual test?

    
    

    
  
I don't think we should invest in testing high-level theme bugs.

    
  
Flags: in-testsuite? → in-testsuite-

          You need to log in
          before you can comment on or make changes to this bug.