Closed
Bug 487518
Opened 14 years ago
Closed 14 years ago
Search widget on OS X shouldn't start search when clicking on non-existent search icon
Categories
(Toolkit :: Themes, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: whimboo, Assigned: dao)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
778 bytes,
patch
|
enndeakin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090408 Shiretoko/3.5b4pre ID:20090408030745 With the change on bug 450800 we support the native look for the search widget on OS X with only a magnifying glass on the left side. There is none on the right side like on other platforms. So clicking on the icon deck shouldn't trigger the search on OS X. Only pressing Enter should do this. We should only remove the event handler for the search icon deck but still handle it when the clear icon is displayed.
Assignee | ||
Updated•14 years ago
|
Component: XUL Widgets → Themes
QA Contact: xul.widgets → themes
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → dao
Attachment #371809 -
Flags: review?(enndeakin)
Reporter | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Updated•14 years ago
|
Attachment #371809 -
Flags: review?(enndeakin) → review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4b1f5eb29671
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Updated•14 years ago
|
Attachment #371809 -
Flags: approval1.9.1?
Comment 3•14 years ago
|
||
Comment on attachment 371809 [details] [diff] [review] patch a191=beltzner
Attachment #371809 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 4•14 years ago
|
||
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090415 Minefield/3.6a1pre ID:20090415030845
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7e7118203ac3
Keywords: checkin-needed → fixed1.9.1
Reporter | ||
Comment 6•14 years ago
|
||
Verified fixed on 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090416 Shiretoko/3.5b4pre ID:20090416030924. Dao, it's bad that we would not be able to detect a regression on OS X with your written test for the search widget. Clicking on the searchIcon while the search widget is in searchButton mode shouldn't trigger a search. Can we integrate it into the test?
Flags: in-testsuite?
Keywords: fixed1.9.1 → verified1.9.1
Assignee | ||
Comment 7•14 years ago
|
||
No. The test is there to test the toolkit binding, which needs to work consistently across platforms.
Reporter | ||
Comment 8•14 years ago
|
||
Means no automated test is possible and we need a manual test?
Assignee | ||
Comment 9•14 years ago
|
||
I don't think we should invest in testing high-level theme bugs.
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite? → in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•