Closed Bug 487538 Opened 11 years ago Closed 11 years ago

bug 487271 left three tests broken in its wake

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: brendan, Assigned: brendan)

References

Details

(Keywords: verified1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch fixesSplinter Review
I didn't notice these until just now:

ecma/Array/15.4.4.4-1.js
ecma/Array/15.4.4.4-2.js
js1_5/extensions/regress-300079.js

Patch fixes all three. Filing separately for best bug hygiene.

The JS_CloneFunctionObject fix compensates for an off-by-one bug fixed by the patch for bug 487271. The PND_FUNARG setting cleanups are for tests that redefine a function that's in the same outer scope as an eval call. The redef makes the original def into a use of the later function of the same name, so we have to synch certain flags used by the analysis.

/be
Flags: blocking1.9.1?
Attachment #371765 - Flags: review?(mrbkap)
Attachment #371765 - Flags: review?(mrbkap) → review+
Fixed in tm:

http://hg.mozilla.org/tracemonkey/rev/671b816a0aa9

/be
Priority: -- → P1
Whiteboard: fixed-in-tracemonkey
Flags: in-testsuite+
http://hg.mozilla.org/mozilla-central/rev/671b816a0aa9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: blocking1.9.1? → blocking1.9.1+
rubber stamp v 1.9.1, 1.9.2. I never saw these in my logs. :-(
Status: RESOLVED → VERIFIED
Target Milestone: mozilla1.9.1b4 → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.