487561 - More cleanup from bug 452498 and bug 487271 patches

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Brendan Eich [:brendan]]

Attachment: cleanups

This also came from some an early look at bug 462734 that went nowhere except to make ASSERT_VALID_PROPERTY_CACHE_HIT call a static helper, so anyone stuck with an assertbotch in that macro can have a hope of debugging. This part is #ifdef DEBUG, so should go into 1.9.1 branch.

The rest is safe optimization/sanity fixing, proof by inspection.

/be

Comment 1

[Igor Bukanov]

Comment on attachment 371806 [details] [diff] [review]
cleanups

>diff --git a/js/src/jsinterp.cpp b/js/src/jsinterp.cpp
>+JS_STATIC_INTERPRET bool
>+js_AssertValidPropertyCacheHit(JSContext *cx, JSScript *script, JSFrameRegs& regs,
>+                               ptrdiff_t pcoff, JSObject *start, JSObject *found,
>+                               JSPropCacheEntry *entry)

The function is always compiled in the same compilation unit as js_Interpret. So it should be just static. r+ on this part of the patch with that fixed.

Comment 2

[Brendan Eich [:brendan]]

Attachment: cleanups I'm about to commit

Comment 3

[Brendan Eich [:brendan]]

Fixed in tm, sayrer will hit m-c shortly:

http://hg.mozilla.org/tracemonkey/rev/547f9171ae0f

/be

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/547f9171ae0f

Comment 5

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/145b1c8acb86