Closed Bug 487561 Opened 11 years ago Closed 11 years ago

More cleanup from bug 452498 and bug 487271 patches

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.1b4

People

(Reporter: brendan, Assigned: brendan)

References

Details

(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

Attached patch cleanups (obsolete) — Splinter Review
This also came from some an early look at bug 462734 that went nowhere except to make ASSERT_VALID_PROPERTY_CACHE_HIT call a static helper, so anyone stuck with an assertbotch in that macro can have a hope of debugging. This part is #ifdef DEBUG, so should go into 1.9.1 branch.

The rest is safe optimization/sanity fixing, proof by inspection.

/be
Attachment #371806 - Flags: review?(mrbkap)
Flags: wanted1.9.1?
Attachment #371806 - Flags: review?(igor)
Priority: -- → P3
Flags: wanted1.9.1? → wanted1.9.1+
Comment on attachment 371806 [details] [diff] [review]
cleanups

>diff --git a/js/src/jsinterp.cpp b/js/src/jsinterp.cpp
>+JS_STATIC_INTERPRET bool
>+js_AssertValidPropertyCacheHit(JSContext *cx, JSScript *script, JSFrameRegs& regs,
>+                               ptrdiff_t pcoff, JSObject *start, JSObject *found,
>+                               JSPropCacheEntry *entry)

The function is always compiled in the same compilation unit as js_Interpret. So it should be just static. r+ on this part of the patch with that fixed.
Attachment #371806 - Flags: review?(mrbkap) → review+
Attachment #371806 - Attachment is obsolete: true
Attachment #371946 - Flags: review+
Attachment #371806 - Flags: review?(igor)
Fixed in tm, sayrer will hit m-c shortly:

http://hg.mozilla.org/tracemonkey/rev/547f9171ae0f

/be
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/547f9171ae0f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.