This also came from some an early look at bug 462734 that went nowhere except to make ASSERT_VALID_PROPERTY_CACHE_HIT call a static helper, so anyone stuck with an assertbotch in that macro can have a hope of debugging. This part is #ifdef DEBUG, so should go into 1.9.1 branch. The rest is safe optimization/sanity fixing, proof by inspection. /be
Attachment #371806 - Flags: review?(mrbkap)
Comment on attachment 371806 [details] [diff] [review] cleanups >diff --git a/js/src/jsinterp.cpp b/js/src/jsinterp.cpp >+JS_STATIC_INTERPRET bool >+js_AssertValidPropertyCacheHit(JSContext *cx, JSScript *script, JSFrameRegs& regs, >+ ptrdiff_t pcoff, JSObject *start, JSObject *found, >+ JSPropCacheEntry *entry) The function is always compiled in the same compilation unit as js_Interpret. So it should be just static. r+ on this part of the patch with that fixed.
Attachment #371806 - Flags: review?(mrbkap) → review+
Fixed in tm, sayrer will hit m-c shortly: http://hg.mozilla.org/tracemonkey/rev/547f9171ae0f /be
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.