487594 - 1 sort operation required by mDBGetTags, do we need an index on bookmarks' titles?

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

with bug 481261 this query will warn due to the fact it cannot use an index to sort (1 sort operation required).

The query is sorting on tag title, that does not have an index, we should evaluate if makes sense to add an index on bookmarks titles (we don't sort often on bookmarks titles) or simply make this not warn.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: stop warning for now

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 371832 [details] [diff] [review]
stop warning for now

r=sdwilsh

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/94cb97a93667

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

leaving open for future investigation on index (this will depend also on what we will do with tags)

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 371832 [details] [diff] [review]
stop warning for now

asking approval to stop warning on 1.9.1 too.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 371832 [details] [diff] [review]
stop warning for now

looks like warnings are not on 1.9.1, right?
clearing request.

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we need bug 424160 in reality.