487649 - Markers handle viewBox and preserveAspectRatio badly

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Markers handle viewBox and preserveAspectRatio badly.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: testcase 1 - you should see what appears to be a circle, not an ellipse

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: testcase 2 - you should see what appears to be a circle, and it should not be clipped

Comment 3

[Jonathan Watt [:jwatt]]

When fixing this bug, care should be taken to make sure that refX and refY are still in the coordinate system established *after* the viewBox and preserveAspectRation transform.

Comment 4

[Robert Longson [:longsonr]]

Attachment: patch

This fixes testcase 1. You'll need to create a new bug for testcase 2.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 456496 [details] [diff] [review]
patch

The ref should be a lot simpler. It should just contain a single circle element. r=jwatt with that change.

For the record, Robert and I were unable to figure out why nsSVGUtils::GetViewBoxTransform has the argument aIgnoreAlign, either from reading the spec or from digging through hg/CVS blame. In fact from the spec it just seems wrong. That's why that argument is being removed.

Comment 6

[Robert Longson [:longsonr]]

pushed http://hg.mozilla.org/mozilla-central/rev/e302434bc8d4