Closed Bug 487865 Opened 15 years ago Closed 15 years ago

Exporting bugs in XML format uses non-unique timezones (they cannot be imported back)

Categories

(Bugzilla :: Bug Import/Export & Moving, defect)

3.3.4
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.4

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

Attached patch patch, v1Splinter Review
Named timezones, such as CET, MSK or EST, are not always unique, and strptime() is unable to parse dates with such timezones if it doesn't recognize them. So we have to fix show.xml.tmpl to not export bugs using named timezones, but to export bugs using the +0100, +0300 or -0600 notation.

I also fix format_time() to remove the unrecognized timezone if it's unable to parse the given date. If parsing fails again, then the date is really not valid and we give up.

This patch is required to correctly fix bug 486006.
Flags: blocking3.4+
Attachment #372123 - Flags: review?(ghendricks)
Attachment #372123 - Flags: review?(ghendricks) → review+
Flags: approval3.4+
Flags: approval+
tip:

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.87; previous revision: 1.86
done
Checking in template/en/default/bug/show.xml.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.xml.tmpl,v  <--  show.xml.tmpl
new revision: 1.30; previous revision: 1.29
done


3.3.4:

Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.86.2.1; previous revision: 1.86
done
Checking in template/en/default/bug/show.xml.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.xml.tmpl,v  <--  show.xml.tmpl
new revision: 1.29.2.1; previous revision: 1.29
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: