487884 - object leak in libpkix library upon error

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Alexei Volkov]

Attachment: Patch v1 - inc ref counter of the request after all assignments are done.

pkix_pl_ocspresponse.c function pkix_pl_OcspResponse_Create: ones new request is created, all fields on the structure should be set to a proper values(including addressed of existing http client session and request) so that ocspresponse destructor would handle the cleanup of the object.

Current code tries to increment ref count first, before variable assignment that leaks session in case when ref count failed.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 372153 [details] [diff] [review]
Patch v1 - inc ref counter of the request after all assignments are done. 

r=nelson
It surely was inobvious how this patch solved the problem, but I'm convinced now.

Comment 2

[Julien Pierre]

Sorry I reset the assignee accidentally when changing the component to "libraries".

Comment 3

[Alexei Volkov]

Attachment: Patch v2 - alternative way to fix the same problem

I have a preference to fix it this way. Code becomes more readable.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 372245 [details] [diff] [review]
Patch v2 - alternative way to fix the same problem

r=nelson