48789 - HTML textfield context menus don't have undo & delete items

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Blake Ross]

Build ID: 2000081208

The context menus for textboxes don't have Undo and Delete menuitems, although 
standard windows textbox context menus do.  (Windows doesn't usually have redo, 
but since we support it, should that be included also?  Don't want to clutter 
up the menu too much...)  Is this deliberate?

Comment 1

[Blake Ross]

->me

Comment 2

[Blake Ross]

Include Redo or not?

Comment 3

[Matthew T (active 1999-2002)]

I really don't think Redo will be commonly used enough. See also bug 16081, bug 
43936, bug 48785. We want consistency here -- to the point of using the same 
overlay, if possible. :-)

(BTW, should this be in XPToolkit/Widgets?)

Comment 4

[Blake Ross]

focusing on xpapps.  reassigning to component owner...

Comment 5

[Ryan Cassin]

I'll assign this to myself, since the fix should be relatively easy. cmanske, 

brade: Do you have any suggestions as to where these menuitems 

should be put in the context menus?

Comment 6

[Kathleen :Brade]

I don't this this is a Composer/Editor bug.  This bug belongs in XPApps or 
XPWidget or ???.  This bug isn't about context menus within Composer but context 
menus on form elements.  Composer already has undo/redo in its context menus (and 
Delete?).

Ryan--I don't know who you'll need to get permission from to check in this fix; 
hopefully a cvsblame on the files you change will guide you.

Comment 7

[Matthew T (active 1999-2002)]

Er, Blake, did you intend this bug to be for HTML form controls? If so, this is a 
dup of bug 16081 (though perhaps those in bug 16081 would appreciate the dup 
being the other way around). If not, we need a clearer summary here.

Anyway, generic spec for context menus of editable items:

  _Undo
--------------------------
  Cu_t
  _Copy
  _Paste
  _Delete
--------------------------
  Select _All
--------------------------  [if there are any field-specific items]
  {field-specific items}    [e.g. auto-complete options]

Comment 8

[Blake Ross]

yes, HTML form controls.  I don't understand why bug 16081 is still open 
(certainly not for the original issue), so I'd hesitate to mark this a dup.

Comment 9

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 10

[amutch]

Apparently, this wasn't an easy fix since this basic feature is still missing
over a year after someone submitted the request. It should be noted that this
functionality is available in Netscape 4.x and in IE 6.0.

Comment 11

[Blake Ross]

-> me

Comment 12

[Blake Ross]

Marking fixed.

Comment 13

[amutch]

Is this marked "fixed" in that it is actually fixed or "fixed" in that we won't
be including these items in the context menus?

Comment 14

[Caspy7]

Fixed.
Works just like it would usually work in Windows.
Try out a nightly build to see it.
Had the bug been denied it would have been marked as WONTFIX or WORKSFORME or 
something more along that lines.

Comment 15

[amutch]

Apparently, this didn't make it down to embedding. It's still not available in
MFCEmbed. I can file a separate bug on that.