48790 - PNG image (4x4 paletted, interlaced) from PngSuite doesn't display

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Eli Goldberg]

s04i3p01.png (attached) from Willem Schaik's PngSuite doesn't display on current 
build.

Checked on Win32/Linux/Mac OS, both as URL, and when contained within a page. 
It's a 4x4 paletted file, interlaced. PngCheck says the file is okay.

Comment 1

[Greg Roelofs]

The attachment doesn't seem to exist, but the direct URL to Willem's copy is
given above.

As far as I can tell, this is an ancient libpng bug that would be cleared up by
upgrading to 1.0.8.  (I believe Mozilla currently still uses 1.0.2, which is
more than two years old.)

Note that the bug affects NN 4.7 as well, so at least we have Navigator
parity...

Comment 2

[Eli Goldberg]

Oops. sorry. started chatting on IRC. will attach now. ;)

Comment 3

[Eli Goldberg]

Attachment: Test image

Comment 4

[tor]

This problem is indeed solved by updating mozilla's libpng to 1.0.8.  Upgrading
is very straightforward, with no source changes needed.  It just requires
dropping in the new files and a couple small tweaks to the makefiles.  
We should probably get this upgrade in the tree.

Comment 5

[pnunn]

tor:
great! 
You want to take this one?
-p

Comment 6

[tor]

Sure, I'll take care of this.  Plan to land:

  * run through png test suite and check for any regressions
  * check new libpng source and win32/unix makefiles into a branch
  * get a mac person to help modify the mac project file
  * find some mac/win32 testers
  * get approval
  * land on tip

Comment 7

[tor]

New libpng is in PNG_20000815_BRANCH of the modules/libimg/png directory.
Unix and Win32 build changes are in the branch.  No build changes are
necessary for MacOS.  Looking for testers now.

Comment 8

[tor]

I've backed out the build changes on the branch.  Those were to enable the
mmx assembly on the appropriate platforms, but the mmx routines are just
quietly aborting the program.  Back to straight C, which runs through the
png test suite without problems.

Comment 9

[tor]

*** Bug 28616 has been marked as a duplicate of this bug. ***

Comment 10

[tor]

Landed the branch.