Closed Bug 487942 Opened 11 years ago Closed 10 years ago

Remove cursor: -moz-alias | -moz-cell | -moz-context-menu | -moz-copy | -moz-spinning

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: moz, Assigned: takenspc)

Details

(Keywords: dev-doc-complete, testcase)

Attachments

(4 files, 1 obsolete file)

Drop support for cursor values
-moz-alias | -moz-cell | -moz-context-menu | -moz-copy| -moz-spinning

The un-prefixed values are supported since Gecko 1.8, "progress" as replacement for "-moz-spinning" since 1.7.
Would be consistent to remove this in 1.9.2 like -moz-outline* (bug 458588).

Daniel, fixing those bugs seems your hobby, so I CCd you.
This patch removes the -moz-cell property which is unused in the tree. It's a CSS 3 value though, but since we implement cursor: cell; already...

@j.j.:
Sadly, in this case I'm not a great help, except for -moz-cell, all other values seem to be dependent on some GTK2 Widget code, see http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsGtkCursors.h

I don't know that code and I can't test changes there. However, all five values are unused and could be removed at any time. In fact, -moz-spinning should be removed since progress is a CSS 2.1 keyword.
Attachment #372230 - Flags: superreview?(dbaron)
Attachment #372230 - Flags: review?(dbaron)
(In reply to comment #1)
> It's a CSS 3 value though, but since we implement cursor: cell; already...

All values are from "CSS3 Basic User Interface Module", which is in CR state since 2004.
Comment on attachment 372230 [details] [diff] [review]
remove: -moz-cell alias
[Checkin: Comment 11]

r+sr=dbaron.

(While we're here, we should probably add the css3 values that we support, and the -moz- values that we're keeping, to layout/style/test/property_database.js.)
Attachment #372230 - Flags: superreview?(dbaron)
Attachment #372230 - Flags: superreview+
Attachment #372230 - Flags: review?(dbaron)
Attachment #372230 - Flags: review+
Attached file CSS cursor testcase (obsolete) —
Includes CSS 2.1, CSS 3, -moz-, -webkit- and IE cursors.
(In reply to comment #3)

> (While we're here, we should probably add the css3 values that we support, and

AFAIK we support all CSS3 values (see testcase), but

- "no-drop"      has bug 275173 on Windows
- "all-scroll"   has bug 275175 on Windows
- "context-menu" not on Windows. Is there any reason why web applications shoudn't use this cursor on windows?
Keywords: testcase
(In reply to comment #5)
> - "all-scroll"   has bug 275175 on Windows

Sorry, should read:
 - "all-scroll"   has bug 275174 on Windows
I added the keywords in the same order used in nsCSSProps.cpp
Attachment #373460 - Flags: superreview?(dbaron)
Attachment #373460 - Flags: review?(dbaron)
Attachment #373460 - Flags: superreview?(dbaron)
Attachment #373460 - Flags: superreview+
Attachment #373460 - Flags: review?(dbaron)
Attachment #373460 - Flags: review+
Comment on attachment 373460 [details] [diff] [review]
property_database.js update
[Checkin: Comment 12]

r+sr=dbaron assuming you've run the tests in layout/style and they still pass :-)
(In reply to comment #8)
> (From update of attachment 373460 [details] [diff] [review])
> r+sr=dbaron assuming you've run the tests in layout/style and they still pass
> :-)

All right, homework done - tests passed :-)
Keywords: checkin-needed
Attached file CSS cursor testcase
Attachment #373406 - Attachment is obsolete: true
Comment on attachment 372230 [details] [diff] [review]
remove: -moz-cell alias
[Checkin: Comment 11]


http://hg.mozilla.org/mozilla-central/rev/19192988b672
Attachment #372230 - Attachment description: remove: -moz-cell alias → remove: -moz-cell alias [Checkin: Comment 11]
Comment on attachment 373460 [details] [diff] [review]
property_database.js update
[Checkin: Comment 12]


http://hg.mozilla.org/mozilla-central/rev/bafeec3a45c8
Attachment #373460 - Attachment description: property_database.js update → property_database.js update [Checkin: Comment 12]
Assignee: nobody → crazy-daniel
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
This is not fixed yet; only one of the values has been removed.

I'd also note that it would be helpful to have clearer checkin comments; it's better not to use the whole title of the bug, but just to say what that particular patch is doing.  That said, it would be helpful if the patch author provided those at the start of the patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: crazy-daniel → nobody
Status: REOPENED → NEW
Target Milestone: mozilla1.9.2a1 → ---
Remove -moz-alias, -moz-cell, -moz-context-menu, -moz-copy and -moz-spinning.
Including tests update.

# http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsGtkCursors.h is not related this bug.
Attachment #403702 - Flags: superreview?(dbaron)
Attachment #403702 - Flags: review?(dbaron)
Flags: wanted1.9.2?
Keywords: dev-doc-needed
Flags: wanted1.9.2? → wanted1.9.2-
Attachment #403702 - Flags: superreview?(dbaron)
Attachment #403702 - Flags: review?(dbaron)
Attachment #403702 - Flags: review+
Comment on attachment 403702 [details] [diff] [review]
Remove -moz-alias, -moz-context-menu, -moz-copy and -moz-spinning 

r=dbaron.  Sorry for the delay
http://hg.mozilla.org/mozilla-central/rev/374169762764

Thanks for the patch.
Assignee: nobody → taken.spc
Status: NEW → RESOLVED
Closed: 11 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.