487980 - Exception... "Cannot find interface information for parameter arg 0 [nsIDOMWindowInternal.pkcs11

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bob Clary [:bc] (inactive)]

ecma/ExecutionContexts/10.2.2-1.js

Exception... "Cannot find interface information for parameter arg 0 [nsIDOMWindowInternal.pkcs11]"  nsresult: "0x80570006 (NS_ERROR_XPC_CANT_GET_PARAM_IFACE_INFO)"  location: "JS frame :: http://test.mozilla.com//tests/mozilla.org/js/ecma/ExecutionContexts/10.2.2-1.js :: <TOP_LEVEL> :: line 91"  data: no];

and similarly for:

ecma/ExecutionContexts/10.2.2-2.js
ecma_2/Statements/forin-002.js
js1_5/Array/regress-108440.js
js1_6/extensions/regress-455464-01.js
js1_6/extensions/regress-455464-02.js
js1_6/extensions/regress-455464-03.js
js1_6/extensions/regress-455464-04.js
js1_6/extensions/regress-475144.js
js1_7/extensions/regress-455982-01.js
js1_7/extensions/regress-455982-02.js
js1_8/extensions/regress-452476.js
js1_8/extensions/regress-476427.js
js1_8_1/trace/trace-test.js

all show this error in the browser. occurs in mozilla-central and tracemonkey.

regressed by bug 326628, http://hg.mozilla.org/mozilla-central/rev/eea9639048b8
sensitive since bug 326628 is.

Comment 1

[Benjamin Smedberg]

This doesn't need to be private. The problem seems to be that because nsIDOMpkcs11 is only a forward-declared interface and never exists, that we can't return it from a method, even though we only ever return "null".

We could either re-add nsIDOMpkcs11 and not implement it anywhere (which seems silly, but it will at least fix the bug, as well as bug 487960), or we could have xpconnect not look for interface info until after it got an object to wrap. The first definitely seems easier, but I'm open to suggestions.

Comment 2

[Benjamin Smedberg]

Attachment: Remove leftover references to nsIDOMPkcs11, rev. 1

On trunk we can just remove the extra references.

On the branch, I just left nsIDOMPkcs11.idl in the tree even though there are no implementers.

Comment 3

[Benjamin Smedberg]

This is only present on trunk, not a branch blocker.

Comment 4

[Bob Clary [:bc] (inactive)]

This is present on tracemonkey. I need it fixed there as well.

Comment 5

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/c41b9f3a9d83

Comment 6

[Bob Clary [:bc] (inactive)]

v 1.9.2. thanks.

Comment 7

[Gregory S. Chudov]

This patch seems to create a problem.

The "Load PKCS#11 Device" dialog (Minefield Preferences->Advanced->Encryption->Security Devices->Load) stops working.

The appropriate code is in mozilla-central\security\manager\pki\resources\content\device_manager.js:

function doLoadDevice()
{
  var name_box = document.getElementById("device_name");
  var path_box = document.getElementById("device_path");
  pkcs11.addmodule(name_box.value, path_box.value, 0,0);
  return true;
}

As pkcs11 reference has been removed, this dialog no longer works and produces the following error message: JavaScript error: chrome://pippki/content/device_manager.js, line 463: pkcs11 is not defined

Comment 8

[Benjamin Smedberg]

Gregory, that's a different bug (and was caused by bug 326628, not this one). Please file it separately and cc me.

Comment 9

[Benjamin Smedberg]

Backed this out with bug 326628... I'll just leave this bug closed and make sure to re-land it if appropriate when bug 326628 relands.