TM: remove amd64 code (will be replaced with tamarin's new amd64 backend)

RESOLVED FIXED

Status

()

P3
normal
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

({fixed1.9.1})

unspecified
x86
Mac OS X
fixed1.9.1
Points:
---
Bug Flags:
blocking1.9.1 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

10 years ago
Created attachment 372258 [details] [diff] [review]
patch

This also fixes a bug in the code generator. We used to emit LEA for constant offset additions, which doesn't update flags, which we do rely on for LIR_ov/LIR_cs. Only use LEA for addp, the address calculation form of addition.
Attachment #372258 - Flags: review?
(Assignee)

Updated

10 years ago
Attachment #372258 - Flags: review? → review?(dvander)
(Assignee)

Comment 2

10 years ago
Seriously, we deleted danderson's account--again?
Comment on attachment 372258 [details] [diff] [review]
patch

Nice catch.
Attachment #372258 - Flags: review?(dvander) → review+
(Assignee)

Comment 4

10 years ago
Please read before granting blocking:

This patch contains a 1-line bug fix. That part should block IMO.

As for the rest, it gets us closer aligned with tamarin-redux, which removed the 386 backend.

I would like to apply the entire patch as is. It should not affect 386 builds. The current 64-bit x86 backend is broken, so it will not really affect x86-64 builds either.

If you want me to split out the bugfix from the code removal patch, I can easily do that.
Flags: blocking1.9.1?

Updated

10 years ago
Priority: -- → P3

Updated

10 years ago
Flags: blocking1.9.1? → blocking1.9.1+
(Assignee)

Comment 5

10 years ago
Ed, do you concur with the LEA change? (and making those if cascades switches)
(Assignee)

Comment 6

10 years ago
http://hg.mozilla.org/tracemonkey/rev/2ee4d920011f
Whiteboard: fixed-in-tracemonkey

Comment 7

10 years ago
yes, sounds right to only use LEA for addp, since we don't track condition code liveness.  when we have time to breathe a bit, we should track cc's better in the backend; lea would be fine for an add if the cc's are not expected.
(Assignee)

Comment 8

10 years ago
Yeah, PPC would benefit from more explicit cc tracking. Sparc probably too, to a lesser degree.

Comment 9

10 years ago
http://hg.mozilla.org/mozilla-central/rev/2ee4d920011f
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.