Closed
Bug 487982
Opened 16 years ago
Closed 16 years ago
arrowscrollbox.scrollByIndex fails if there are gaps between the elements
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
9.55 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
arrowscrollbox.scrollByIndex fails if there are gaps between the elements. I'm seeing this using the mouse wheel in a bookmark menu on Linux, where menuseparators have a margin.
Attachment #372259 -
Flags: review?(enndeakin)
|
||
Updated•16 years ago
|
Attachment #372259 -
Flags: review?(enndeakin) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 372259 [details] [diff] [review]
patch
>+ if (aX < elements[low].getBoundingClientRect()[start] ||
>+ aX > elements[high].getBoundingClientRect()[end])
>+ return null;
There should be an if (!elements.length) return above this
I think we could really use a scrollbox test.
|
Assignee | |
Comment 2•16 years ago
|
||
Bug 475203 adds some tests for the tabstrip (one of our two arrowscrollbox consumers), but I'm also going to write some generic toolkit tests.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•