487982 - arrowscrollbox.scrollByIndex fails if there are gaps between the elements

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

arrowscrollbox.scrollByIndex fails if there are gaps between the elements. I'm seeing this using the mouse wheel in a bookmark menu on Linux, where menuseparators have a margin.

Comment 1

[Neil Deakin]

Comment on attachment 372259 [details] [diff] [review]
patch

>+          if (aX < elements[low].getBoundingClientRect()[start] ||
>+              aX > elements[high].getBoundingClientRect()[end])
>+            return null;

There should be an if (!elements.length) return above this

I think we could really use a scrollbox test.

Comment 2

[Dão Gottwald [:dao]]

Bug 475203 adds some tests for the tabstrip (one of our two arrowscrollbox consumers), but I'm also going to write some generic toolkit tests.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/10528984d5fd