488027 - summarize_time.cgi compares strings using numeric lt (<)

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

summarize_time.cgi: Argument "2008-01-28" isn't numeric in numeric lt (<) at data/template/template/en/default/bug/summarize-time.html.tmpl line 499.

The line is:

  [% IF bugs.$id.deadline && global.deadline < bugs.$id.deadline %]


This is a regression due to bug 286452. Should be fixed before 3.4rc1.

Comment 1

[Frédéric Buclin]

You should try foo.deadline.replace("-", "") < bar.deadline.replace("-", ""). This should fix your problem as Perl is supposed to convert them to integers implicitly.

Comment 2

[Teemu Mannermaa (:wicked)]

Attachment: Fix numeric compare, V1

It worked perfectly. Additionally this patch protects from comparing with blank global deadline field that happens before a first non-blank bug deadline field is found.

Comment 3

[Frédéric Buclin]

Comment on attachment 373566 [details] [diff] [review]
Fix numeric compare, V1

r=LpSolit

Comment 4

[Teemu Mannermaa (:wicked)]

Tip:
Checking in template/en/default/bug/summarize-time.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/summarize-time.html.tmpl,v  <--  summarize-time.html.tmpl
new revision: 1.15; previous revision: 1.14
done

3.4 branch:
Checking in template/en/default/bug/summarize-time.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/summarize-time.html.tmpl,v  <--  summarize-time.html.tmpl
new revision: 1.14.2.1; previous revision: 1.14
done